feat(autopatch): only delete versionissue links when no component ins…#1229
Merged
Conversation
…tance is attached to component version.
drochow
requested review from
MR2011,
copyonwrite,
dorneanu and
michalkrzyz
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the MariaDB autopatch cleanup flow so that ComponentVersionIssue links are only removed when a component version is actually safe to delete (i.e., when it has no remaining component instances).
Changes:
- Removed the unconditional “remove all issues from component versions” step during autopatch processing.
- Moved issue-link removal to occur alongside component version deletion when the version has no remaining instances.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
283
to
293
| if len(res) == 0 { | ||
| for vIdDi := range versionIdsOfDisappearedInstances { | ||
| if err := s.RemoveAllIssuesFromComponentVersion(vIdDi); err != nil { | ||
| return err | ||
| } | ||
| } | ||
| if err := s.DeleteComponentVersion(vIdDi, util.SystemUserId); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| } |
MR2011
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.