Skip to content

docs(sidebar): keep demo trigger position stable #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattrothenberg merged 3 commits into from
Sep 30, 2026
Merged

docs(sidebar): keep demo trigger position stable #829

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1373fc0
docs(sidebar): keep demo trigger position stable
mattrothenberg Sep 29, 2026
35e3f38
Merge branch 'main' into codex/stable-sidebar-toggle
mattrothenberg Sep 29, 2026
197fb75
fix(docs): preserve sidebar footer identity
mattrothenberg Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 29 additions & 18 deletions packages/kumo-docs-astro/src/components/demos/SidebarDemo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,17 @@ function DemoMain({ children }: { children?: React.ReactNode }) {
);
}

/**
* Keeps the footer action aligned with the collapsed rail. The library footer
* deliberately gains breathing room in its expanded state; these demos use a
* single bottom-left action, so retaining its x-position makes the transition
* easier to follow.
*/
function DemoSidebarFooter({ children }: { children: React.ReactNode }) {
return <Sidebar.Footer className="!px-[11px]">{children}</Sidebar.Footer>;
}
Comment thread
mattrothenberg marked this conversation as resolved.
DemoSidebarFooter.displayName = "Sidebar.Footer";

function BrandLogo() {
return (
<div className="flex w-full min-w-0 items-center gap-2 px-3 transition-[padding] duration-(--sidebar-animation-duration) ease-(--sidebar-easing) group-data-[state=collapsed]/sidebar:px-2">
Expand Down Expand Up @@ -311,9 +322,9 @@ export function SidebarToggleDemo() {
</Sidebar.Menu>
</Sidebar.Group>
</Sidebar.Content>
<Sidebar.Footer>
<DemoSidebarFooter>
<Sidebar.Trigger />
</Sidebar.Footer>
</DemoSidebarFooter>
</Sidebar>
<DemoMain>
<ToggleButton />
Expand Down Expand Up @@ -360,9 +371,9 @@ export function SidebarLoadingDemo() {
</Sidebar.Group>
</Sidebar.Content>
)}
<Sidebar.Footer>
<DemoSidebarFooter>
<Sidebar.Trigger />
</Sidebar.Footer>
</DemoSidebarFooter>
</Sidebar>
<DemoMain>
<button
Expand Down Expand Up @@ -415,9 +426,9 @@ export function SidebarResizableDemo() {
</Sidebar.Menu>
</Sidebar.Group>
</Sidebar.Content>
<Sidebar.Footer>
<DemoSidebarFooter>
<Sidebar.Trigger />
</Sidebar.Footer>
</DemoSidebarFooter>
<Sidebar.ResizeHandle />
</Sidebar>
<DemoMain>
Expand Down Expand Up @@ -517,9 +528,9 @@ export function SidebarPeekingDemo() {
</Sidebar.Menu>
</Sidebar.Group>
</Sidebar.Content>
<Sidebar.Footer>
<DemoSidebarFooter>
<Sidebar.Trigger />
</Sidebar.Footer>
</DemoSidebarFooter>
</Sidebar>
<DemoMain>
<PeekStateIndicator />
Expand Down Expand Up @@ -610,9 +621,9 @@ export function SidebarAutoScrollDemo() {
</Sidebar.Menu>
</Sidebar.Group>
</Sidebar.Content>
<Sidebar.Footer>
<DemoSidebarFooter>
<Sidebar.Trigger />
</Sidebar.Footer>
</DemoSidebarFooter>
</Sidebar>
<DemoMain>
<p>Open Workers near the bottom of the list</p>
Expand Down Expand Up @@ -677,9 +688,9 @@ export function SidebarTransitionCompleteDemo() {
</Sidebar.Menu>
</Sidebar.Group>
</Sidebar.Content>
<Sidebar.Footer>
<DemoSidebarFooter>
<Sidebar.Trigger />
</Sidebar.Footer>
</DemoSidebarFooter>
</Sidebar>
<DemoMain>
<p aria-live="polite">{completion}</p>
Expand Down Expand Up @@ -943,9 +954,9 @@ export function SidebarFullDemo() {
</Sidebar.SlidingView>
</Sidebar.SlidingViews>

<Sidebar.Footer>
<DemoSidebarFooter>
<Sidebar.Trigger />
</Sidebar.Footer>
</DemoSidebarFooter>
</Sidebar>
<DemoMain />
</Sidebar.Provider>
Expand Down Expand Up @@ -1041,9 +1052,9 @@ export function SidebarScrollToItemDemo() {
</Sidebar.Menu>
</Sidebar.Group>
</Sidebar.Content>
<Sidebar.Footer>
<DemoSidebarFooter>
<Sidebar.Trigger />
</Sidebar.Footer>
</DemoSidebarFooter>
</Sidebar>
<DemoMain>
<ScrollToItemControls />
Expand Down Expand Up @@ -1105,9 +1116,9 @@ export function SidebarMobileDemo() {
</Sidebar.Menu>
</Sidebar.Group>
</Sidebar.Content>
<Sidebar.Footer>
<DemoSidebarFooter>
<Sidebar.Trigger />
</Sidebar.Footer>
</DemoSidebarFooter>
</Sidebar>
<DemoMain>
<MobileToggleButton />
Expand Down
Loading