docs(sidebar): keep demo trigger position stable

[mattrothenberg]

Summary

• keep the sidebar trigger at the same horizontal position while docs demos collapse and expand
• apply the shared stable footer treatment across sidebar examples

Validation

• Astro check (0 errors; existing hints only)

• manually verified the sidebar docs interaction locally

• Reviews

• bonk has reviewed the change

• automated review not possible because: this is a small visual docs adjustment verified interactively.

• Tests

• Tests included/updated

• Automated tests not possible - manual testing has been completed as follows: toggled the sidebar in the local docs page and confirmed the footer trigger remains fixed.

• Additional testing not necessary because: no component behavior or public API changed.

[cloudflare-workers-and-pages]

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://codex-stable-sidebar-toggle-kumo-docs.design-engineering.workers.dev (commit 197fb75)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status	Deployment URL	Commit	Updated (UTC)	See this deployment's details
Build: Success ✅ Deployment: Success ✅ View logs ↗	https://50d2dac2-kumo-docs.design-engineering.workers.dev	197fb75	2026-09-29T22:29:23.561Z	Visit the dashboard ↗
Build: In progress 🔵 View logs ↗		35e3f38	2026-09-29T22:24:13.885Z	View logs ↗

[ask-bonk]

I'm Bonk, and I've done a quick review of your PR.

Posted 1 inline finding.

Review notes

• Confirmed the review target is PR docs(sidebar): keep demo trigger position stable #829 (docs(sidebar): keep demo trigger position stable). I’ll inspect the docs package guidance, full changed component, pull-request patch, and existing review feedback before assessing the interaction behavior.
• Reviewed the PR patch and its only changed file. It introduces one footer wrapper and replaces the matching footer instances in nine interactive sidebar demos; PR docs(sidebar): keep demo trigger position stable #829 currently has no published reviews to duplicate. Next I’m verifying the sidebar footer’s sizing and mobile semantics against its component implementation.
• Verified the sidebar implementation identifies footer children only by the direct child component’s displayName === "Sidebar.Footer" and keeps them outside the peek zone. The new wrapper does not carry that display name, so each wrapped footer is treated as ordinary content; this makes the peeking demo’s trigger itself activate peeking, contrary to the component’s documented behavior. I’m checking existing inline comments, then will post this verified regression with a minimal suggestion.
• Checked for existing inline comments and reviews; none were present. Posted one inline comment on the new wrapper with a suggestion that preserves the footer identity required by the sidebar’s child partitioning.

github run

[github-actions]

Visual contracts

Linux Chromium references exercised by the PR's visual-contracts job.

1 curated contract

truncating text trigger

[pkg-pr-new]

npm i https://pkg.pr.new/@cloudflare/kumo@829

commit: 197fb75

[github-actions]

📐 Bundle Size

Consumer fixtures bundled against packages/kumo/dist (peers external, minified ESM).

Fixture	Raw	Gzip	Brotli
Button (root)	166.3 KB	50.9 KB	44.1 KB
Button (components/button)	166.2 KB	50.9 KB	44.1 KB
Button + Dialog + Select (root)	291.1 KB	86.8 KB	72.9 KB
Button + Dialog + Select (component subpaths)	291.1 KB	86.8 KB	72.8 KB
Chart (root)	238.6 KB	72.0 KB	61.8 KB
Chart (components/chart)	238.6 KB	72.0 KB	61.9 KB
Badge (components/badge)	36.5 KB	12.7 KB	11.1 KB
Flow (components/flow)	200.6 KB	59.2 KB	51.7 KB
Button (primitives/button)	12.2 KB	4.4 KB	3.9 KB
Primitives barrel	635.8 KB	176.8 KB	139.3 KB
Code highlighting (code)	2.07 MB	469.2 KB	350.4 KB

npm tarball: 546 files, 1.49 MB packed, 6.93 MB unpacked.

⚠️ 24 flagged files in tarball (tests / raw scripts)

• dist/blocks-source/delete-resource/delete-resource.test.tsx
• dist/blocks-source/resource-list/resource-list.test.tsx
• scripts/component-registry/cache.ts
• scripts/component-registry/discovery.ts
• scripts/component-registry/example-cleanup.ts
• scripts/component-registry/index.test.ts
• scripts/component-registry/index.ts
• scripts/component-registry/markdown-generator.ts
• scripts/component-registry/metadata.ts
• scripts/component-registry/props-filter.ts
• scripts/component-registry/schema-generator.ts
• scripts/component-registry/sub-components.ts
• scripts/component-registry/types.ts
• scripts/component-registry/utils.ts
• scripts/component-registry/variant-parser.ts
• scripts/css-build.ts
• scripts/generate-globe-land-mask.mjs
• scripts/generate-primitives.ts
• scripts/theme-generator/config.ts
• scripts/theme-generator/generate-css.test.ts
• scripts/theme-generator/generate-css.ts
• scripts/theme-generator/index.ts
• scripts/theme-generator/migrate.ts
• scripts/theme-generator/types.ts

Report-only: no size thresholds are enforced yet.

Commit: 197fb758

[mattrothenberg]

/bonk can you approve through the GitHub UI pretty plz

[ask-bonk]

LGTM!

Review notes

• Confirmed the target is PR docs(sidebar): keep demo trigger position stable #829 and inspected its current diff, reviews, and inline comments.
• Reviewed the full changed demo file and the sidebar footer partitioning implementation.
• Verified the prior footer-identity finding is addressed by setting DemoSidebarFooter.displayName to Sidebar.Footer.
• No actionable issues found. No approval was submitted because repository review policy permits review comments only.

github run