Repository navigation
docs(pdf): the cv.md shape the CV checks read, Pandoc output included, and "title check did not run" - #158
Open
vliggio wants to merge 1 commit into
Open
docs(pdf): the cv.md shape the CV checks read, Pandoc output included, and "title check did not run"#158vliggio wants to merge 1 commit into
vliggio wants to merge 1 commit into
Conversation
…, and "title check did not run" Documents what career-ops-hq/career-ops#4880 shipped (merged as 2b3fb67): the three CV checks read Pandoc-flavored cv.md through one shared helper, cv-title-check no longer prints a green check after comparing nothing, and doctor warns when cv.md has no Experience section the checks can read. One new section on the pdf mode page, "How your cv.md is read": the shape the checks need, the accepted section names, that a cv.md converted from a Word file with Pandoc is read as it is, and what you see when the checks cannot find your jobs. English, Spanish, French and German. translationHash restamped to the new English hash (6c9e87b81634e369); all three matched the previous one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@vliggio is attempting to deploy a commit to the Career Ops OSS Program Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 34 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents what career-ops-hq/career-ops#4880 shipped (merged as
2b3fb67): the three CV checks read Pandoc-flavoredcv.mdthrough one shared helper,cv-title-checkno longer prints a green check after comparing nothing, anddoctorwarns whencv.mdhas no Experience section the checks can read. The site describedcv.mdonly as "standard sections" and said nothing about the shape the checks depend on.What changes
One new section, "How your cv.md is read", on the pdf mode page, before "Gotchas". English, Spanish, French and German.
examples/cv-example.md: the five accepted experience-section names, the### Company — Locationjob heading and its accepted separators, the bold title line, the dates line.cv.mdconverted from a Word file with Pandoc is read as it is (bold and small-caps headings,---/--dashes, trailing\breaks).title check did not runinstead of a green check, and thenpm run doctorwarning, which is a warning and never a failure.Each statement was checked against
lib/cv-markdown.mjs,cv-title-check.mjs,jd-skill-gap.mjs,doctor.mjs,modes/pdf.mdandAGENTS.mdon coremainafter the merge, not against the PR as first reviewed.One sentence that is not in the core PR text
"These heading names are matched in English, even when the rest of your CV is in another language." It follows from the regexes (
EXPERIENCE_HEADING_REinlib/cv-markdown.mjs,SKILLS_WORD_RE/TOOLS_WORD_REinjd-skill-gap.mjs), which match English words only. It matters most to readers of the translated pages, who are the likeliest to have acv.mdwith## Experienciaor## Berufserfahrung.Scope
The FAQ answer "How do I give career-ops my CV?" is the other natural home for the shape. It is left alone here because several open pull requests already edit
faq.mdxandsrc/lib/faq-data.ts.Translations
translationHashis restamped ones,franddeto the new English hash (6c9e87b81634e369). All three matched the previous English hash (16914eae2d8e7aa4) before this change, so the restamp is accurate. The three translations were written with Claude and have not had a native-speaker read. The examplecv.mdblock stays in English in every language, because the headings in it are the ones the checks match.Merge order
A sibling pull request (#157) adds a second section to the same four files for career-ops-hq/career-ops#4764. Whichever merges second needs a rebase and a restamp. With both sections in place (this one first, then the ATS section), the English hash is
ec87532bd085bfa0.Checks
npm run types:check: passesnpm run build: passes🤖 Generated with Claude Code