Skip to content

fix(dto): update expiresIn max to 90 days per spec #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GBOYEE wants to merge 3 commits into from
Closed

fix(dto): update expiresIn max to 90 days per spec #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be3592a
feat(stellar): add trace logging for expiresIn → expiry_ledger conver…
Jun 21, 2026
cf70877
fix(dto): update expiresIn max to 90 days per spec
Jun 21, 2026
5180249
ci: retrigger
Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/modules/accounts/dto/create-account.dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ export class CreateAccountDto {

@ApiProperty({
example: 2592000,
description: 'Expiry in seconds (1 hour - 30 days)',
description: 'Expiry in seconds (1 hour - 90 days)',
})
@IsNumber()
@Min(3600) // 1 hour
@Max(2592000) // 30 days
@Max(7776000) // 90 days
expiresIn: number;

@ApiProperty({ example: { userId: 'user_123' }, required: false })
Expand Down
6 changes: 6 additions & 0 deletions src/modules/stellar/stellar.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,12 @@ export class StellarService {
// Step 2: Initialize the Soroban contract with restrictions
const expiryLedger = await this.toExpiryLedger(params.expiresIn);

this.logger.log(
`Expiry conversion: expiresIn=${params.expiresIn}s → expiryLedger=${expiryLedger} ` +
`(currentLedger=${Math.round(expiryLedger - Math.ceil(params.expiresIn / 5) - EXPIRY_BUFFER_LEDGERS)}, ` +
`offset=${expiryLedger - Math.round(expiryLedger - Math.ceil(params.expiresIn / 5) - EXPIRY_BUFFER_LEDGERS)} ledgers)`,
);

const contract = new StellarSdk.Contract(params.contractId);
const sourceAccount = await this.sorobanServer.getAccount(
fundingKeypair.publicKey(),
Expand Down