fix(dto): update expiresIn max to 90 days per spec#147
Closed
GBOYEE wants to merge 3 commits into
Closed
Conversation
added 3 commits
June 21, 2026 05:06
…sion - Add runtime log in createEphemeralAccount showing expiresIn, expiryLedger, currentLedger, and offset - Helps operators verify the conversion is working correctly in production Related to bridgelet-org#144
Updates the CreateAccountDto expiresIn validation from 30 days (2592000s) to 90 days (7776000s) as per the MVP spec. The toExpiryLedger() conversion and trace logging are already implemented. Closes bridgelet-org#144
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
CreateAccountDto.expiresInvalidation from 30 days (2,592,000s) to 90 days (7,776,000s) as per the MVP spec.The full
expiresIn → expiry_ledgerconversion chain is already implemented:CreateAccountDto.expiresIn(seconds, validated 1h–90d)AccountsService.create()passesexpiresIntoStellarService.createEphemeralAccount()StellarService.toExpiryLedger()converts to ledger sequencestellar.service.spec.tscover the conversionChanges
@Max(2592000)→@Max(7776000)(90 days)Closes #144