feat: serve fiat logos from login.blockchain.com (FC-2303) - #553
Open
lparkesneptune-bc wants to merge 1 commit into
Open
feat: serve fiat logos from login.blockchain.com (FC-2303)#553lparkesneptune-bc wants to merge 1 commit into
lparkesneptune-bc wants to merge 1 commit into
Conversation
Second stage of moving coin-definitions asset images off the public GitHub repo. The 30 fiat logos in fiat.json now point at /static/asset/currency/fiat/<ISO>.png, served from service-wallet-frontend-static-assets rather than raw.githubusercontent.com. Fiat.expected_logo_url() derives that URL from the symbol alone, so no lookup table is needed. logo_path() stays as-is: the local files under extensions/fiats/ are still the source of truth for the existence and duplicate-content checks, and are not deleted here. Do not merge until the matching static-assets commit is deployed — the URLs 404 until then. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Points the 30
fiat.jsonlogo URLs atlogin.blockchain.com/staticinstead ofraw.githubusercontent.com.The images are already published and deployed to the static assets host; all 30 URLs verified returning
200 image/png.Fiat.expected_logo_url()derives the URL from the symbol alone. The files underextensions/fiats/are unchanged and still drive the existence and duplicate-content checks../check.shpasses.