feat: serve coin and token logos from login.blockchain.com (FC-2303) - #554
Draft
lparkesneptune-bc wants to merge 1 commit into
Conversation
Repoints the remaining 8,138 logo URLs - 74 coins and 8,064 tokens - at our own
CDN, so this repo no longer publishes image URLs of its own and no longer
hotlinks third-party hosts.
coin/<chain key>.png
token/<chain>/<contract address>.png
build_currency_logo and build_token_logo now derive the URL from the asset's
identity instead of from where the bytes happen to live. build_token_logo loses
its local-file check entirely; build_currency_logo keeps one, because the local
files still decide *whether* a coin has a logo at all, just not what its URL is.
The generated lists are rewritten with the same rule and verified to match what
the build now produces, so the next build is a no-op for these fields. No
third-party logo URL remains in any list. ./check.sh passes.
The 34 assets whose upstream source 404s are repointed like the rest. Their
logos are broken today and stay broken, at a different URL, until the images are
dropped or replaced - tracked separately.
Two extension override inputs under extensions/blockchains/ still carry
third-party logo fields. They are build inputs rather than published URLs, and
one of them the build never reads.
Do not merge until the matching images are deployed to the static assets host.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
lparkesneptune-bc
force-pushed
the
FC-2303-serve-coin-and-token-logos-from-cdn
branch
from
August 28, 2026 15:12
0036b81 to
e5b2f73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Points the remaining 8,138 logo URLs — 74 coins and 8,064 tokens — at
login.blockchain.com/static, so no list holds a third-party or GitHub-hosted logo URL any more.build_currency_logoandbuild_token_logonow derive the URL from the asset's identity rather than from where the bytes live, and the generated lists are rewritten to match, so the next build is a no-op for these fields../check.shpasses.Draft: do not merge until the images are deployed to the static assets host, or every coin and token logo 404s. Stacked on #553.
Two things left alone deliberately: the 34 assets whose upstream image already 404s are repointed like the rest, and newly discovered tokens still get a CoinGecko URL from
coin_gecko.py— changing that means a new token also needs its image published first, which is a workflow decision.