Backfill coverage gaps and exclude non-product files from coverage - #290
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Code Metrics Report
Details | | master (1c84fe4) | #290 (f3cdb31) | +/- |
|---------------------|------------------|----------------|-------|
+ | Coverage | 99.5% | 100.0% | +0.4% |
| Files | 114 | 111 | -3 |
| Lines | 3616 | 3595 | -21 |
- | Covered | 3598 | 3595 | -3 |
+ | Test Execution Time | 21s | 19s | -2s |Code coverage of files in pull request scope (94.7% → 100.0%)
Reported by octocov |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #288, rebuilt on top of current master (post-octocov, #289). The content is @pnzrfst's work, cherry-picked as a single clean commit with his authorship — the original branch carried the couve commits from #285/#286, which were closed in favor of #289.
What it does
width_boxfromnfce_lib/header.rb— dead code since Shrink licensee name to fit #159 (2021), never called.method_missing/respond_to_missing?delegation in the threeDocumentclasses (cce_lib, danfe_lib/nfe_lib, danfe_lib/nfce_lib). Each was mutation-tested manually in Backfill coverage gaps closed by the gate #288./lib/prawn/(Prawn internals monkey-patch, from Backfill coverage gaps closed by the gate #288) and/spec/support/(rescued from Fail the PR when its changed files aren't fully covered #286, orphaned when it was closed).Result
Line coverage goes from 99.5% to 100.0% (3595/3595) — verified locally with the full suite green.
The octocov comment on this PR is also the first real demonstration of the delta against the master baseline recorded since #289 landed.
🤖 Generated with Claude Code