Skip to content

Clean up and reduce global styles#2602

Draft
lllarsen wants to merge 2 commits into
testfrom
lily/reduceglobalstyles
Draft

Clean up and reduce global styles#2602
lllarsen wants to merge 2 commits into
testfrom
lily/reduceglobalstyles

Conversation

@lllarsen
Copy link
Copy Markdown
Contributor

@lllarsen lllarsen commented May 30, 2026

Summary

Organizes all global styles and reduces reliance on global styling.

  • Cleanup global stylesheets seperating into seperate files as needed
  • Reduce usage of global styles.
  • Ensure UI is the same as before the introduction of this PR

Global styles which can be reduced:

  • All styling of material components (styles/global/material.scss and styles/global/targeted.scss) will be moved to style tokens (not in this pr)
  • NoUi should be able to be styled using component level stylesheets since it is not a third party component. If true, should be able to directly import styles/global/noUI.scss in all components which directly utilize a noUI slider, and then move noUi styles from global/targeted.scss into their respective component styles. (verify?)
  • styles/global/shortcuts.scss can either be imported by each component as boilerplate, or kept as a global style (the invalid input animation in styles.scss is in a similar situation)
  • styles/global/timeseries.scss should be able to be imported by its respective component.
  • there are some miscellaneous styling by id in styles.scss that must get sorted out, and then styles.scss will be left as setting the theme, typography and styling .cdk-*
  • There is no good solution for removing toast theming from global styles, however it is archived so it will likely be replaced by material components anyways.

Related Issues

TOOL-4333

Screenshots / UI Changes

<Insert before/after screenshots or GIFs if this touches UI>

i18n

  • No hardcoded user-facing strings
  • New or modified translation keys are documented below

i18n keys changed/added

  • KEY_PATH_ONE –
  • KEY_PATH_TWO –

Tests & Build

  • npm run lint passes
  • npm test passes (or N/A)
  • npm run build succeeds

@lllarsen lllarsen force-pushed the lily/reduceglobalstyles branch 2 times, most recently from 1607071 to b647f30 Compare June 1, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant