test: introduce visual regression testing for styles refactoring#2610
Draft
lllarsen wants to merge 2 commits into
Draft
test: introduce visual regression testing for styles refactoring#2610lllarsen wants to merge 2 commits into
lllarsen wants to merge 2 commits into
Conversation
lllarsen
force-pushed
the
lily/visualregressiontesting
branch
from
00f0151 to
4412a4d
Compare
williamh890
reviewed
Jun 5, 2026
| await page | ||
| .getByRole('menuitem', { name: 'Baseline Baseline search' }) | ||
| .click(); | ||
| await expect(page).toHaveScreenshot(); |
Comment on lines
+22
to
+34
| await expect(page).toHaveScreenshot(); | ||
|
|
||
| await page.getByRole('button', { name: '1/1/2015', exact: true }).click(); | ||
| await expect(page).toHaveScreenshot(); | ||
|
|
||
| await page.getByRole('button', { name: '/1/2015' }).click(); | ||
|
|
||
| await openEndDateCalendar.click(); | ||
| await page.getByRole('button', { name: '2015' }).click(); | ||
| await expect(page).toHaveScreenshot(); | ||
|
|
||
| await page.getByRole('button', { name: '1/1/2015', exact: true }).click(); | ||
| await expect(page).toHaveScreenshot(); |
Collaborator
There was a problem hiding this comment.
These can go. The calendar is pretty much a default angular component.
Comment on lines
7
to
+66
| @@ -20,6 +22,8 @@ test('Map: Gridlines Overlay toggle updates checkbox state', async ({ | |||
| }); | |||
|
|
|||
| await layerButton.click(); | |||
| await expect(page).toHaveScreenshot(); | |||
|
|
|||
| await gridlinesItem.click(); | |||
|
|
|||
| await layerButton.click(); | |||
| @@ -35,6 +39,8 @@ test('Map: Coherence Layer activates when a month range is selected', async ({ | |||
| const coherenceItem = page.getByRole('menuitem', { name: 'Coherence Layer' }); | |||
|
|
|||
| await layerButton.click(); | |||
| await expect(page).toHaveScreenshot(); | |||
|
|
|||
| await coherenceItem.click(); | |||
| await page.getByRole('menuitem', { name: 'Mar, Apr, May' }).click(); | |||
|
|
|||
| @@ -51,10 +57,14 @@ test('Map: switch base layer between Satellite and Street', async ({ | |||
| const layerIcon = layerButton.locator('mat-icon.control-icon'); | |||
|
|
|||
| await layerButton.click(); | |||
| await expect(page).toHaveScreenshot(); | |||
|
|
|||
| await page.getByRole('menuitem', { name: 'Street Layer' }).click(); | |||
| await expect(layerIcon).toHaveText('directions_car'); | |||
|
|
|||
| await layerButton.click(); | |||
| await expect(page).toHaveScreenshot(); | |||
Collaborator
There was a problem hiding this comment.
All these look the same on my machine.
| await sbasFiltersButton.click(); | ||
|
|
||
| await page.getByRole('textbox', { name: 'Start Date' }).fill('9/1/2018'); | ||
| await expect(page).toHaveScreenshot(); |
Collaborator
There was a problem hiding this comment.
I would move this up so it's 'both empty' and 'both filled' for date filters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces visual regression testing for refactoring of styles
Related Issues
Tooling for #2602
Screenshots / UI Changes
N/A
i18n
N/A
Tests & Build
npm run lintpassesnpm testpasses (or N/A)npm run buildsucceeds