Repository navigation
TS SDK: Add conditional branching with dag.if - #74069
Merged
Merged
Conversation
This was referenced Oct 2, 2026
guan404ming
changed the title
guan404ming
force-pushed
the
ts-sdk-dag-if
branch
3 times, most recently
from
October 2, 2026 07:36
e78c3f6 to
2f647ea
Compare
guan404ming
marked this pull request as ready for review
October 2, 2026 07:38
guan404ming
force-pushed
the
ts-sdk-dag-if
branch
2 times, most recently
from
October 2, 2026 07:47
f9be893 to
67ab684
Compare
guan404ming
changed the title
guan404ming
force-pushed
the
ts-sdk-dag-if
branch
from
October 2, 2026 07:53
67ab684 to
f5ab127
Compare
jason810496
reviewed
Oct 2, 2026
guan404ming
force-pushed
the
ts-sdk-dag-if
branch
from
October 2, 2026 10:47
f5ab127 to
fdfceb4
Compare
jason810496
approved these changes
Oct 6, 2026
jason810496
left a comment
jason810496
left a comment
Member
There was a problem hiding this comment.
Thanks for the update.
No concern from me, and no finding from the claude review.
pierrejeambrun
approved these changes
Oct 6, 2026
pierrejeambrun
left a comment
pierrejeambrun
left a comment
Member
There was a problem hiding this comment.
LGTM thanks only one thing to address I believe.
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
guan404ming
force-pushed
the
ts-sdk-dag-if
branch
from
October 6, 2026 16:58
fdfceb4 to
fd127aa
Compare
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
dag.switch)Why
iftakes the deciding function, not a placed task.How
dag.if(fn, inputs?, spec?).then(a).else(b), taking a trailingTaskSpecas Go'sdag.Ifdoes.task.after(gate)works as in Go.Was generative AI tooling used to co-author this PR?