Repository navigation
TS SDK: Add triggerDagRun to native Dags - #74071
Merged
Merged
Conversation
guan404ming
changed the title
guan404ming
force-pushed
the
ts-sdk-trigger-dag-run
branch
4 times, most recently
from
October 2, 2026 07:47
4ba6faa to
69b2f9b
Compare
guan404ming
changed the title
guan404ming
marked this pull request as ready for review
October 2, 2026 07:55
jason810496
reviewed
Oct 6, 2026
Member
There was a problem hiding this comment.
Thanks for the PR, LGTM overall, here're some findings by claude review that make sense to me.
Not all of them are blocking comments.
Rest of the SDKs (Java and Go) should follow this PR to implement the trigger DagRun runtime to ensure the consistent behavior.
guan404ming
force-pushed
the
ts-sdk-trigger-dag-run
branch
from
October 6, 2026 15:23
69b2f9b to
2ce1929
Compare
Member
Author
|
Thanks for the review! Addressed the doubled JSDoc openers, |
jason810496
force-pushed
the
ts-sdk-trigger-dag-run
branch
from
October 7, 2026 02:50
2ce1929 to
4fba955
Compare
jason810496
approved these changes
Oct 7, 2026
Member
|
Just a head up, I will force push this PR as I just merge #74070. |
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
jason810496
force-pushed
the
ts-sdk-trigger-dag-run
branch
from
October 7, 2026 05:07
4fba955 to
af5d485
Compare
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
Why
How
dag.task(triggerDagRun(spec), { taskId })(), mirroring Go'sdag.Task(airflow.TriggerDagRun(spec), ...).waitForCompletionanddeferrablesupport.Was generative AI tooling used to co-author this PR?