Skip to content

Fix mapped tasks does not validate task_id - #70135

Closed
Andrushika wants to merge 1 commit into
apache:mainfrom
Andrushika:validate-mapped-task-id
Closed

Andrushika wants to merge 1 commit into
apache:mainfrom
Andrushika:validate-mapped-task-id

Conversation

@Andrushika

@Andrushika Andrushika commented Jul 20, 2026 •

Copy link
Copy Markdown
Contributor

Validate task_id for mapped tasks

Why

A regular task validates its task_id in BaseOperator.__init__. A mapped task is built on a path that skips __init__, so its id was never validated. A regular task and a mapped task then accept different sets of ids, breaking the invariant that every task_id is validated:

MyOperator(task_id="bad*id")                      # raises
MyOperator.partial(task_id="bad*id").expand(...)  # passed silently

The taskflow @task mapped form had the same gap.

What

Validate the id in both mapped paths, at the point where the final id is known (after the task-group prefix and unique-suffix), matching BaseOperator.__init__. Valid ids are unaffected. Tests lock that the final id is validated, not the raw one.

related: #69965, #69937

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: Claude Code Opus 4.8 following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

A regular task validates its task_id in BaseOperator.__init__, but a
mapped task is built through a different path that skips __init__, so its
task_id was never checked. An invalid id such as "bad*id" passed
silently in .partial().expand() and in the taskflow @task mapped form,
only to fail later where the id is used. Validate the id in both mapped
paths so it is rejected at parse time like a regular task.
@Andrushika
Andrushika force-pushed the validate-mapped-task-id branch from d5ee49a to 581708c Compare July 20, 2026 14:46
@Andrushika Andrushika changed the title Validate task_id for mapped tasks Fix mapped tasks does not validate task_id Jul 20, 2026
@Andrushika

Copy link
Copy Markdown
Contributor Author

Hi @kaxil, could you please take a look if you have time? Thanks a lot!

@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label Aug 13, 2026
@Andrushika

Copy link
Copy Markdown
Contributor Author

Hi @ashb, if it's possible, could you please take a look on this PR? Thanks!

@potiuk potiuk added the closed because of open PR limit Closed as a one-time step of introducing the open pull request limit label Sep 25, 2026
@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @Andrushika - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 7 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdk closed because of open PR limit Closed as a one-time step of introducing the open pull request limit ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants