Repository navigation
Fix mapped tasks does not validate task_id - #70135
Andrushika wants to merge 1 commit into
Conversation
A regular task validates its task_id in BaseOperator.__init__, but a mapped task is built through a different path that skips __init__, so its task_id was never checked. An invalid id such as "bad*id" passed silently in .partial().expand() and in the taskflow @task mapped form, only to fail later where the id is used. Validate the id in both mapped paths so it is rejected at parse time like a regular task.
d5ee49a to
581708c
Compare
|
Hi @kaxil, could you please take a look if you have time? Thanks a lot! |
|
Hi @ashb, if it's possible, could you please take a look on this PR? Thanks! |
|
Hello @Andrushika - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 7 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Validate task_id for mapped tasks
Why
A regular task validates its
task_idinBaseOperator.__init__. A mapped task is built on a path that skips__init__, so its id was never validated. A regular task and a mapped task then accept different sets of ids, breaking the invariant that everytask_idis validated:The taskflow
@taskmapped form had the same gap.What
Validate the id in both mapped paths, at the point where the final id is known (after the task-group prefix and unique-suffix), matching
BaseOperator.__init__. Valid ids are unaffected. Tests lock that the final id is validated, not the raw one.related: #69965, #69937
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code Opus 4.8 following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.