Repository navigation
Preserve AirflowTaskTimeout when timeout logging fails - #69713
Andrushika wants to merge 2 commits into
Conversation
…eout When SIGALRM fires in a task-runner whose supervisor pipe is broken, self.log.error inside the signal handler raises BrokenPipeError, which propagates in place of AirflowTaskTimeout. The task then exits with the wrong exception class and skips task_runner's timeout-handling path — visible in the traceback attached to apache#64212 (handle_timeout -> log.error -> structlog _write -> BrokenPipeError, AirflowTaskTimeout absent). Suppress OSError around the log call so a broken pipe at the log sink cannot mask the timeout. OSError matches the evidence in apache#64212 — BrokenPipeError's parent class — without broadening to Exception; whether the scope should be wider is left as an open question for review. Two other links of the same failure chain were already fixed in apache#66572 and apache#67955. Related to apache#64212.
Dev-iL
left a comment
There was a problem hiding this comment.
Generally LGTM. The one suggestion I have is: it's unnecessary to add the full explanation of why the suppress is needed into the source code - readers interested in more context can go read the PR. I would replace the multiline comment with something simpler like "Ensure the timeout isn't masked by a logging error" or "Ensure the timeout gets reported" or even "Disregard logging errors {so timeout surfaces}" - you get the idea.
Fixed, thanks for reviewing! |
|
Hi @amoghrajesh, could you please take a look when you have time? |
|
Hello @Andrushika - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 7 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Preserve AirflowTaskTimeout when timeout logging fails
Why
handle_timeout()logs a timeout message before raisingAirflowTaskTimeout. The task runtime sends those logs through a pipe handled by the supervisor. If that pipe has been closed (for example, because the supervisor has exited), the logging call can raiseBrokenPipeErrorinstead.This masks the original timeout, causing the task to fail with a logging error rather than
AirflowTaskTimeout. This exact sequence appears in the production traceback in #64212.What
Suppress
OSErrorraised while logging fromhandle_timeout()so a failed log write cannot mask the timeout.handle_timeout()will still raiseAirflowTaskTimeoutafter a logging failure. Non-OSError exceptions from the logging stack are deliberately left out of scope.related: #64212
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code Opus 4.7 following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.