Skip to content

Preserve AirflowTaskTimeout when timeout logging fails - #69713

Closed
Andrushika wants to merge 2 commits into
apache:mainfrom
Andrushika:fix-handle-timeout-log-swallow-64212
Closed

Andrushika wants to merge 2 commits into
apache:mainfrom
Andrushika:fix-handle-timeout-log-swallow-64212

Conversation

@Andrushika

@Andrushika Andrushika commented Jul 10, 2026 •

Copy link
Copy Markdown
Contributor

Preserve AirflowTaskTimeout when timeout logging fails

Why

handle_timeout() logs a timeout message before raising AirflowTaskTimeout. The task runtime sends those logs through a pipe handled by the supervisor. If that pipe has been closed (for example, because the supervisor has exited), the logging call can raise BrokenPipeError instead.
This masks the original timeout, causing the task to fail with a logging error rather than AirflowTaskTimeout. This exact sequence appears in the production traceback in #64212.

What

Suppress OSError raised while logging from handle_timeout() so a failed log write cannot mask the timeout. handle_timeout() will still raise AirflowTaskTimeout after a logging failure. Non-OSError exceptions from the logging stack are deliberately left out of scope.

related: #64212

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: Claude Code Opus 4.7 following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

…eout

When SIGALRM fires in a task-runner whose supervisor pipe is broken,
self.log.error inside the signal handler raises BrokenPipeError, which
propagates in place of AirflowTaskTimeout. The task then exits with the
wrong exception class and skips task_runner's timeout-handling path —
visible in the traceback attached to apache#64212 (handle_timeout -> log.error
-> structlog _write -> BrokenPipeError, AirflowTaskTimeout absent).

Suppress OSError around the log call so a broken pipe at the log sink
cannot mask the timeout. OSError matches the evidence in apache#64212 —
BrokenPipeError's parent class — without broadening to Exception;
whether the scope should be wider is left as an open question for
review. Two other links of the same failure chain were already fixed in
apache#66572 and apache#67955.

Related to apache#64212.
@Andrushika Andrushika mentioned this pull request Jul 10, 2026
1 of 2 tasks
@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label Jul 11, 2026

@Dev-iL Dev-iL left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. The one suggestion I have is: it's unnecessary to add the full explanation of why the suppress is needed into the source code - readers interested in more context can go read the PR. I would replace the multiline comment with something simpler like "Ensure the timeout isn't masked by a logging error" or "Ensure the timeout gets reported" or even "Disregard logging errors {so timeout surfaces}" - you get the idea.

@Andrushika

Copy link
Copy Markdown
Contributor Author

it's unnecessary to add the full explanation of why the suppress is needed into the source code - readers interested in more context can go read the PR.

Fixed, thanks for reviewing!

@Andrushika

Copy link
Copy Markdown
Contributor Author

Hi @amoghrajesh, could you please take a look when you have time?
It's a one line change plus test, thanks a lot!

@potiuk potiuk added the closed because of open PR limit Closed as a one-time step of introducing the open pull request limit label Sep 25, 2026
@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @Andrushika - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 7 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdk closed because of open PR limit Closed as a one-time step of introducing the open pull request limit ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants