Repository navigation
aeon skill: plugin-root fallback for mine-history, fresh CI counts, drop pr-check, no em/en dashes - #1183
Merged
Conversation
…rop pr-check, no em/en dashes Four fixes to the aeon setup skill, applied identically to both copies (.claude/skills/aeon and plugin/skills/aeon): 1. Mode 8 history mining: Claude Code does not export CLAUDE_PLUGIN_ROOT (or PLUGIN_ROOT) to Bash, so the plugin copy's miner command expands to /skills/aeon/scripts/mine-history.mjs and node fails with MODULE_NOT_FOUND. Add a fallback note next to the command in SKILL.md and references/history-mining.md: run it from the skill's base directory. The plugin-root path transform stays at 5 lines. 2. references/ci.md and references/layout.md counted 13 ci-*.yml and 18 workflows. There are 15 ci-*.yml (14 path-filtered plus ci-gate) and 20 workflows. Add table rows for ci-aeon-skill-sync and ci-harness-cli. 3. Mode 8 named pr-check as an Aeon skill; there is no skills/pr-check. Point at pr-review only. 4. Replace every em dash and en dash in both copies with a plain hyphen (house style, as in #743).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four fixes to the
aeonsetup skill. Every change is applied identically to both copies (.claude/skills/aeon/**andplugin/skills/aeon/**);bash scripts/check-aeon-skill-sync.shpasses and the intentional plugin-root path difference is still exactly 5 lines.1. Mode 8 miner command fails in the Claude Code plugin
The plugin copy runs
node "${PLUGIN_ROOT:-$CLAUDE_PLUGIN_ROOT}/skills/aeon/scripts/mine-history.mjs" .... Claude Code does not exportCLAUDE_PLUGIN_ROOT(orPLUGIN_ROOT) to Bash, so the path expands to/skills/aeon/scripts/mine-history.mjsand node exits withMODULE_NOT_FOUND.Fix: a fallback note right after the command in
SKILL.md(Mode 8 step 1) and after the "Running it" block inreferences/history-mining.md: if the path comes out bare and node fails, runnode <skill base dir>/scripts/mine-history.mjs ...from the skill's base directory (the "Base directory for this skill" line Claude Code prints when the skill loads). The note uses no plugin-root variable, so the wording is identical in both copies and the sync check's path transform is untouched.2. Stale CI counts
.github/workflows/on main has 20 workflows, 15 of themci-*.yml(14 path-filtered plusci-gate).references/ci.md: "Thirteen ... Twelve path-filtered ... the thirteenth ... the other twelve" becomes Fifteen / Fourteen / fifteenth / fourteen. Added table rows forci-aeon-skill-sync(.claude/skills/aeon/**,plugin/skills/aeon/**,scripts/check-aeon-skill-sync.sh; runbash scripts/check-aeon-skill-sync.sh) andci-harness-cli(harness-adapter, install/run-grok/llm-gateway/ccr scripts, aeon.yml + messages.yml workflows, smoke + fake-upstream test files; runbash scripts/tests/harness_cli_smoke.sh <harness>).references/layout.md: "18 workflows ... 13 ci-*.yml" becomes 20 / 15.3.
pr-checkis not an Aeon skillSKILL.mdMode 8 step 3 and the overlap table inreferences/history-mining.mdlistedpr-review/pr-check. There is noskills/pr-checkupstream (skills/pr-reviewexists). Now namespr-reviewonly. The other skills named nearby (digest,mention-radar,article,github-monitor,changelog,shiplog,heartbeat) all exist.4. No em or en dashes
Replaced all 183 em dashes and 5 en dashes per copy (7 files each, incl. three
'-'empty-list placeholders and comments inscripts/mine-history.mjs) with plain hyphens: " - " for spaced dashes,2-3style for ranges. House style, as in #743.node --checkpasses on the script and it still prints its clean no-history error.No other directories touched. The hosted website mirror of this skill will be picked up by the docs-sync flow separately.