Skip to content

Toolkit method update for REST API DatasourceResources controller#6

Draft
zack-rma wants to merge 7 commits into
adamkorynta:devops/refactor-integration-fixturesfrom
zack-rma:devops/refactor-integration-fixtures_datasource_resources
Draft

Toolkit method update for REST API DatasourceResources controller#6
zack-rma wants to merge 7 commits into
adamkorynta:devops/refactor-integration-fixturesfrom
zack-rma:devops/refactor-integration-fixtures_datasource_resources

Conversation

@zack-rma

@zack-rma zack-rma commented Jan 9, 2025

Copy link
Copy Markdown

Problem Description

Only distinction between a not found error and other DatabaseExceptions was the error message String.

Solution

Adds a ValueNotFoundException throwable to the DatabaseException thrown when a requested item is not found.

how you tested the change

Tested in REST API against OpenTSDB instance.

Where the following done:

  • Tests. Check all that apply:
    • Unit tests created or modified that run during ant test.
    • Integration tests created or modified that run during integration testing
      (Formerly called regression tests.)
    • Test procedure descriptions for manual testing
  • Was relevant documentation updated?
  • Were relevant config element (e.g. XML data) updated as appropriate

If you aren't sure leave unchecked and we will help guide you to want needs changing where.

@adamkorynta adamkorynta force-pushed the devops/refactor-integration-fixtures branch from 500efb2 to d9cdd7f Compare January 22, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants