DatasourceResources Controller Refactor with Integration Testing for OpenTSDB#323
Conversation
zack-rma
added this to the
F0215 Task 2.2 - OpenTSDB: Integration Testing Controllers milestone
|
rma-rripken
left a comment
rma-rripken
left a comment
There was a problem hiding this comment.
Getting there. I think there are some changes that need to be fixed or fixed via rebase
|
Build will fail since it is dependent on Toolkit changes found here: adamkorynta/opendcs#6 |
zack-rma
changed the title
Are you expecting it to fail with a |
I wasn't. I tried to recreate that error on my end, but haven't been able to yet. I'm unsure of the source of those failures at the moment, but it's possible that there's a testing configuration tweak needed. I'll see if this pops up elsewhere or if I can narrow down the cause. |
zack-rma
force-pushed
the
feature/task_cwms_support_datasource_resources_it
branch
from
b440a4f to
c26b684
Compare
zack-rma
force-pushed
the
feature/task_cwms_support_datasource_resources_it
branch
from
c26b684 to
15f545e
Compare
…rt_datasource_resources_it
| } | ||
| catch (ValueNotFoundException ex) | ||
| { | ||
| throw new DatabaseItemNotFoundException(notFound + dataSourceId + "."); |
There was a problem hiding this comment.
need to add the exception parameter
There was a problem hiding this comment.
Added exception cause
…OpenTSDB (#323) DataSourceResources Controller refactor with integration testing
…OpenTSDB (#323) DataSourceResources Controller refactor with integration testing
4 participants
Problem Description
Fixes #236.
Solution
Implements integration testing coverage for refactored DatasourceResources controller.
how you tested the change
Integration testing included.
Where the following done:
(Formerly called regression tests.)
If you aren't sure leave unchecked and we will help guide you to want needs changing where.