Skip to content

Method Implementation to Support DatatypeUnitResources Controller Refactor#2

Open
zack-rma wants to merge 16 commits into
adamkorynta:devops/refactor-integration-fixturesfrom
zack-rma:devops/refactor-integration-fixtures_datatype_resources
Open

Method Implementation to Support DatatypeUnitResources Controller Refactor#2
zack-rma wants to merge 16 commits into
adamkorynta:devops/refactor-integration-fixturesfrom
zack-rma:devops/refactor-integration-fixtures_datatype_resources

Conversation

@zack-rma

@zack-rma zack-rma commented Jan 3, 2025

Copy link
Copy Markdown

Problem Description

Fixes #224.

Implements missing functionality in OpenDCS that was being utilized in the REST API. Adds UnitConverter write/deletion, datatype retrieval with filtering by standard String value.

Solution

Utilizes existing methods where possible. Adds UnitConverter write/deletion, datatype retrieval with filtering by standard String value. XML unit converter deletion is in progress.

how you tested the change

Tested within the REST API using integration tests against OpenTSDB.

Where the following done:

  • Tests. Check all that apply:
    • Unit tests created or modified that run during ant test.
    • Integration tests created or modified that run during integration testing
      (Formerly called regression tests.)
    • Test procedure descriptions for manual testing
  • Was relevant documentation updated?
  • Were relevant config element (e.g. XML data) updated as appropriate

If you aren't sure leave unchecked and we will help guide you to want needs changing where.

@zack-rma zack-rma marked this pull request as ready for review January 17, 2025 19:24
@adamkorynta adamkorynta force-pushed the devops/refactor-integration-fixtures branch from 500efb2 to d9cdd7f Compare January 22, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants