Method Implementation to Support DatatypeUnitResources Controller Refactor#2
Open
zack-rma wants to merge 16 commits into
Conversation
This was referenced Jan 3, 2025
…tor-integration-fixtures_datatype_resources
500efb2 to
d9cdd7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
Fixes #224.
Implements missing functionality in OpenDCS that was being utilized in the REST API. Adds UnitConverter write/deletion, datatype retrieval with filtering by standard String value.
Solution
Utilizes existing methods where possible. Adds UnitConverter write/deletion, datatype retrieval with filtering by standard String value. XML unit converter deletion is in progress.
how you tested the change
Tested within the REST API using integration tests against OpenTSDB.
Where the following done:
(Formerly called regression tests.)
If you aren't sure leave unchecked and we will help guide you to want needs changing where.