Uncomment Delete Method in UnitConverterIO#1
Draft
zack-rma wants to merge 5 commits into
Draft
Conversation
zack-rma
changed the base branch from
unused
to
devops/refactor-integration-fixtures
6 tasks
adamkorynta
force-pushed
the
devops/refactor-integration-fixtures
branch
from
554a4ed to
500efb2
Compare
adamkorynta
force-pushed
the
devops/refactor-integration-fixtures
branch
from
500efb2 to
d9cdd7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
Solves missing delete method for unit converters.
Solution
Un-comment existing delete method.
how you tested the change
DB access not tested currently.
Where the following done:
(Formerly called regression tests.)
If you aren't sure leave unchecked and we will help guide you to want needs changing where.