Repository navigation
fix(rest): read status=TASK_STATE_UNSPECIFIED as no filter - #488
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
muscariello
force-pushed
the
stack/20-rest-status-unspecified-no-filter
branch
from
November 3, 2026 20:52
00cc8fe to
67df77b
Compare
muscariello
force-pushed
the
stack/20-rest-status-unspecified-no-filter
branch
from
November 3, 2026 22:39
67df77b to
2e2427c
Compare
muscariello
force-pushed
the
stack/20-rest-status-unspecified-no-filter
branch
from
November 4, 2026 08:16
2e2427c to
9ff0a1f
Compare
lgecse
approved these changes
Nov 4, 2026
TASK_STATE_UNSPECIFIED is the proto default for an unset status, and the JSON-RPC and gRPC bindings read it as "no filter". The REST binding passed it on as a filter, so GET /tasks?status=TASK_STATE_UNSPECIFIED matched no task at all while the same ListTasks over JSON-RPC returned every task. Signed-off-by: gulldan <5641375+gulldan@users.noreply.github.com>
muscariello
force-pushed
the
stack/20-rest-status-unspecified-no-filter
branch
from
November 4, 2026 11:57
9ff0a1f to
7a3d8e5
Compare
lgecse
approved these changes
Nov 4, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #482. Replaces #483.
Cause: the REST binding turned
status=TASK_STATE_UNSPECIFIEDinto a filter no task matches, while JSON-RPC and gRPC read the proto default as "no filter" (pbconv.rs). OneListTasksanswered every task on one binding and none on another (§5.1).Fix:
handle_list_tasksmapsTaskState::UnspecifiedtoNone. Unknown values are still refused with "invalid status filter".Tests:
test_list_tasks_status_unspecified_is_no_filter: after onePOST /message:send,GET /tasks?status=TASK_STATE_UNSPECIFIEDreportstotalSize: 1; onmainit reports 0.Unproven: not built together with #468 (open), which changes this handler's extractor; the two merge without conflict.