Repository navigation
Conversation
TASK_STATE_UNSPECIFIED is the proto default for an unset status, and the JSON-RPC and gRPC bindings read it as "no filter". The REST binding passed it on as a filter, so GET /tasks?status=TASK_STATE_UNSPECIFIED matched no task at all while the same ListTasks over JSON-RPC returned every task. Co-Authored-By: Claude Mythos 5.1 <noreply@anthropic.com> Signed-off-by: gulldan <5641375+gulldan@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
Replaced by #488. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #482.
Problem
The REST binding turned
status=TASK_STATE_UNSPECIFIEDinto a filter no task can match, while JSON-RPC and gRPC read the proto default as "no filter". OneListTasksanswered every task on one binding and none on another (§5.1).Fix
handle_list_tasksmapsTaskState::UnspecifiedtoNonebefore building the request, the same reading the other two bindings already have. Unknown values are still refused with "invalid status filter".Tests
test_list_tasks_status_unspecified_is_no_filter: after onePOST /message:send,GET /tasks?status=TASK_STATE_UNSPECIFIEDreportstotalSize: 1. Onmainit reports 0.main3f3dea6: all green (869 tests). Patch coverage ascoverage.ymlbuilds it: 26 coverable added lines, 0 missed.Overlap
One commit on
main; two lines ina2a-server/src/rest.rs. #468 (tenant paths) touches the same handler's signature, not this match; whichever lands second rebases trivially.🤖 Generated with Claude Code