-
Notifications
You must be signed in to change notification settings - Fork 16
Add management command for finding new version #1910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Add management command for finding newest Argus release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| from django.core.management.base import BaseCommand | ||
|
|
||
| from argus.versioncheck.models import LastSeenVersion | ||
| from argus.versioncheck.tasks import get_latest_version | ||
|
|
||
|
|
||
| class Command(BaseCommand): | ||
| help = "Look for a new Argus version" | ||
|
|
||
| def add_arguments(self, parser): | ||
| parser.add_argument("-s", "--save", action="store_true", help="Save the new version to the database") | ||
|
|
||
| def handle(self, *args, **options): | ||
| latest_version = get_latest_version() | ||
| self.stdout.write(f"Latest version of Argus is: {latest_version}") | ||
| if options["save"]: | ||
| _, created = LastSeenVersion.objects.get_or_create(version=latest_version) | ||
| if created: | ||
| self.stdout.write("Saved to database.") | ||
| else: | ||
| self.stdout.write("This version is already in the database.") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| from unittest.mock import patch | ||
|
|
||
| from django.test import TestCase, tag | ||
|
|
||
| from argus.versioncheck.models import LastSeenVersion | ||
| from django.core.management import call_command | ||
| from argus.util.testing import connect_signals, disconnect_signals | ||
|
|
||
|
|
||
| @tag("database") | ||
| class TestTaskRegisterLatestVersion(TestCase): | ||
| def setUp(self): | ||
| disconnect_signals() | ||
|
|
||
| def tearDown(self): | ||
| connect_signals() | ||
|
|
||
| @patch("argus.versioncheck.tasks.get_latest_version") | ||
| def test_when_new_version_is_not_already_registered_then_register_new_version(self, get_latest_version): | ||
| get_latest_version.return_value = "1.2.3" | ||
| assert not LastSeenVersion.objects.filter(version="1.2.3").exists() | ||
| call_command("check_version", "--save") | ||
| assert LastSeenVersion.objects.filter(version="1.2.3").exists() | ||
|
|
||
| @patch("argus.versioncheck.tasks.get_latest_version") | ||
| def test_when_new_version_is_already_registered_then_do_not_register_it_again(self, get_latest_version): | ||
| get_latest_version.return_value = "1.2.3" | ||
| LastSeenVersion.objects.create(version="1.2.3") | ||
| assert LastSeenVersion.objects.filter(version="1.2.3").count() == 1 | ||
| call_command("check_version", "--save") | ||
| # Still only one instance of this version in the database | ||
| assert LastSeenVersion.objects.filter(version="1.2.3").count() == 1 | ||
|
|
||
| @patch("argus.versioncheck.tasks.get_latest_version") | ||
| def test_when_save_flag_is_not_set_then_do_not_register_new_version(self, get_latest_version): | ||
| get_latest_version.return_value = "1.2.3" | ||
| assert not LastSeenVersion.objects.filter(version="1.2.3").exists() | ||
| call_command("check_version") | ||
| assert not LastSeenVersion.objects.filter(version="1.2.3").exists() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to note in #1882 to remove this comment when it is implemented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍