Skip to content

Add management command for finding new version#1910

Merged
hmpf merged 2 commits into
mainfrom
add-management-command-for-finding-new-version
Apr 29, 2026
Merged

Add management command for finding new version#1910
hmpf merged 2 commits into
mainfrom
add-management-command-for-finding-new-version

Conversation

@stveit

@stveit stveit commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Scope and purpose

Fixes #1907

Adds a management command that looks for a new Argus release and optionally saves it in the database for future use

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation, including updates to the user manual if feature flow or UI is considerably changed
  • Linted/formatted the code with ruff and djLint, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See our how-to
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this results in changes to the database model: Updated the ER diagram

@stveit stveit self-assigned this Apr 28, 2026
@github-actions

github-actions Bot commented Apr 28, 2026

Copy link
Copy Markdown

Test results

    6 files  1 254 suites   2m 28s ⏱️
  912 tests   911 ✅ 1 💤 0 ❌
5 472 runs  5 466 ✅ 6 💤 0 ❌

Results for commit 084c1df.

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Apr 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.32%. Comparing base (fb449f1) to head (084c1df).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1910      +/-   ##
==========================================
+ Coverage   88.25%   88.32%   +0.07%     
==========================================
  Files         141      142       +1     
  Lines        6871     6887      +16     
==========================================
+ Hits         6064     6083      +19     
+ Misses        807      804       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/argus/versioncheck/tasks.py Outdated

@hmpf hmpf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about user agent.

@stveit stveit mentioned this pull request Apr 28, 2026
8 tasks
@stveit stveit force-pushed the add-management-command-for-finding-new-version branch from 4754cc6 to 04ead9e Compare April 28, 2026 09:55
@stveit

stveit commented Apr 28, 2026

Copy link
Copy Markdown
Contributor Author

See comment about user agent.

Fixed in #1908 , which is now merged

@johannaengland johannaengland requested review from a team, hmpf and johannaengland April 28, 2026 11:56

@johannaengland johannaengland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest renaming the command to check_version to follow the pattern we already have established that is verb_noun

@hmpf hmpf force-pushed the add-management-command-for-finding-new-version branch from 084c1df to 19133a2 Compare April 29, 2026 07:45
@hmpf hmpf merged commit a8333af into main Apr 29, 2026
8 of 15 checks passed
@hmpf hmpf deleted the add-management-command-for-finding-new-version branch April 29, 2026 07:45
@sonarqubecloud

Copy link
Copy Markdown

Comment on lines +595 to +596
This will currently not do anything, but in the future you will be able to get
a notification in the frontend if there is a new release registered in the database that you haven't seen yet.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to note in #1882 to remove this comment when it is implemented

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add management command for finding new argus version

3 participants