bugfix: Clear stealth when driver killed by neutron/sniper

[Copilot]

Stealthed vehicles hit by neutron shells or Jarmen Kell remain permanently invisible, undetectable even by stealth detectors.

Root Cause

StealthUpdate::allowedToStealth() doesn't check DISABLED_UNMANNED state. When driver is killed, vehicle becomes unmanned but stealth persists.

Changes

Added disabled check in allowedToStealth() for both games:

// GeneralsMD/StealthUpdate.cpp (line 314)
if( self->isDisabledByType( DISABLED_UNMANNED ) )
{
    return FALSE;
}

// Generals/StealthUpdate.cpp (line 206) 
if( self->isDisabledByType( DISABLED_UNMANNED ) )
{
    return false;
}

Existing logic in update() automatically clears OBJECT_STATUS_STEALTHED when allowedToStealth() returns false.

Notes

• No CRC gating needed: OBJECT_STATUS_STEALTHED is client-side visual state, not synced
• Return style matches each codebase's convention (GeneralsMD: uppercase FALSE, Generals: lowercase false)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Stealthed units don't lose stealth state when driver is killed</issue_title>
<issue_description>### Prerequisites

• I have searched for similar issues and confirmed this is not a duplicate

Game Version

• Command & Conquer Generals
• Command & Conquer Generals: Zero Hour
• Other (please specify below)

Bug Description

Units that were stealthed before their driver / crew was killed by Neutron shells (and Jarmen Kell probably) remain in stealth mode indefinitely. They don't become visible for enemies even with stealth detectors.

Reproduction Steps

See content below.

Additional Context

POV player 1:

stealth_unit_without_driver.mp4

POV player 2:

</issue_description>

Comments on the Issue (you are @copilot in this section)

@Caball009 - May be related to: https://github.com//issues/47

• Fixes Stealthed units don't lose stealth state when driver is killed #1994

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[tintinhamans]

@greptileai

[greptile-apps]

Greptile Overview

Greptile Summary

This PR fixes a gameplay bug where vehicles hit by neutron shells or sniped by Jarmen Kell remained permanently invisible even to stealth detectors. The fix adds a check for DISABLED_UNMANNED state in StealthUpdate::allowedToStealth(), ensuring that when a vehicle's driver is killed (which sets the DISABLED_UNMANNED flag), the stealth status is automatically cleared through the existing update logic.

Key Changes:

• Added DISABLED_UNMANNED check in allowedToStealth() for both Generals and GeneralsMD codebases
• Fix correctly leverages existing update() logic that clears OBJECT_STATUS_STEALTHED when allowedToStealth() returns false
• No CRC gating required as OBJECT_STATUS_STEALTHED is client-side visual state
• Return type conventions respected (uppercase FALSE for GeneralsMD, lowercase false for Generals)

Analysis:
The root cause is confirmed - neutron shells (NeutonBlastBehavior.cpp:141) and sniper damage (ActiveBody.cpp:426) set the DISABLED_UNMANNED flag when killing vehicle drivers, but stealth persisted because allowedToStealth() didn't check this disabled state. The fix is minimal, targeted, and integrates cleanly with the existing stealth management system.

Confidence Score: 5/5

• This PR is safe to merge - it's a focused bug fix with clear logic and minimal changes
• The fix is surgically precise, adding only a necessary disabled state check that logically belongs in the stealth validation logic. The implementation correctly leverages existing update mechanisms, maintains codebase conventions, and addresses a confirmed gameplay bug without introducing side effects.
• No files require special attention - both changes are identical in logic and appropriate for their respective codebases

Important Files Changed

Filename	Overview
GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/StealthUpdate.cpp	Added DISABLED_UNMANNED check in allowedToStealth() to prevent stealthed vehicles from remaining invisible when driver killed
Generals/Code/GameEngine/Source/GameLogic/Object/Update/StealthUpdate.cpp	Added DISABLED_UNMANNED check in allowedToStealth() mirroring GeneralsMD fix for vanilla game compatibility

Sequence Diagram

sequenceDiagram
    participant Neutron as Neutron Shell/Jarmen Kell
    participant Body as ActiveBody/NeutonBlastBehavior
    participant Object as Vehicle Object
    participant Stealth as StealthUpdate
    participant Status as Visual Status

    Neutron->>Body: Kill driver (DAMAGE_KILLPILOT)
    Body->>Object: setDisabled(DISABLED_UNMANNED)
    Note over Object: Vehicle now unmanned<br/>but still stealthed (BUG)
    
    loop Every frame
        Stealth->>Stealth: update()
        Stealth->>Stealth: allowedToStealth()
        Note over Stealth: NEW: Check DISABLED_UNMANNED
        alt Vehicle is unmanned
            Stealth-->>Stealth: return FALSE
            Stealth->>Status: clearStatus(OBJECT_STATUS_STEALTHED)
            Note over Status: Vehicle becomes visible
        else Vehicle has driver
            Stealth-->>Stealth: return TRUE
            Stealth->>Status: setStatus(OBJECT_STATUS_STEALTHED)
            Note over Status: Vehicle stays hidden
        end
    end

Loading

[greptile-apps]

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}