Skip to content

fix(shadow): Fix crash by initializing debris shadow name to an empty string #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Stubbjax wants to merge 4 commits into
base: main
Choose a base branch
from
+24 −3
Open

fix(shadow): Fix crash by initializing debris shadow name to an empty string #2221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be8b95a
refactor: Implement cleaner solution
Stubbjax Jan 30, 2026
9a4b87a
refactor: Remove explicit constructor calls
Stubbjax Jan 31, 2026
5947e58
docs: Remove comments
Stubbjax Jan 31, 2026
6efd776
tweak: Remove more unnecessary defaults
Stubbjax Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DTreeBuffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,14 +697,11 @@ void W3DTreeBuffer::loadTreesInVertexAndIndexBuffers(RefRenderObjListIterator *p

if (m_shadow == nullptr && TheW3DProjectedShadowManager) {
Shadow::ShadowTypeInfo shadowInfo;
shadowInfo.m_ShadowName[0] = 0;
shadowInfo.allowUpdates=FALSE; //shadow image will never update
shadowInfo.allowWorldAlign=TRUE; //shadow image will wrap around world objects
shadowInfo.m_type = (ShadowType)SHADOW_DECAL;
shadowInfo.m_sizeX=20;
shadowInfo.m_sizeY=20;
shadowInfo.m_offsetX=0;
shadowInfo.m_offsetY=0;
m_shadow = TheW3DProjectedShadowManager->createDecalShadow(&shadowInfo);
}

Expand Down
12 changes: 12 additions & 0 deletions Generals/Code/GameEngine/Include/GameClient/Shadow.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,18 @@ class Shadow

struct ShadowTypeInfo
{
ShadowTypeInfo()
{
m_ShadowName[0] = '\0';
m_type = SHADOW_NONE;
allowUpdates = false;
allowWorldAlign = false;
m_sizeX = 0.0f;
m_sizeY = 0.0f;
m_offsetX = 0.0f;
m_offsetY = 0.0f;
}

char m_ShadowName[64]; //when set, overrides the default model shadow (used mostly for Decals).
ShadowType m_type; //type of shadow
Bool allowUpdates; //whether to update the shadow image when object/light moves.
Expand Down
12 changes: 12 additions & 0 deletions GeneralsMD/Code/GameEngine/Include/GameClient/Shadow.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,18 @@ class Shadow

struct ShadowTypeInfo
{
ShadowTypeInfo()
{
m_ShadowName[0] = '\0';
m_type = SHADOW_NONE;
allowUpdates = false;
allowWorldAlign = false;
m_sizeX = 0.0f;
m_sizeY = 0.0f;
m_offsetX = 0.0f;
m_offsetY = 0.0f;
}

char m_ShadowName[64]; //when set, overrides the default model shadow (used mostly for Decals).
ShadowType m_type; //type of shadow
Bool allowUpdates; //whether to update the shadow image when object/light moves.
Expand Down
Loading