Make example-skills-catalog catalog recording optional - #69
Merged
Conversation
Step 7 previously assumed every user maintains a ~/my-claude-skills catalog repo and would hard-fail (cd into a nonexistent directory) for anyone who doesn't. Check for its existence first and skip silently when absent -- it's a personal convenience convention, not required for the generated skill to work.
3 tasks
dmccoystephenson
added a commit
that referenced
this pull request
Jul 27, 2026
…nce (#77) Step 1 told the generator to diff against /tmp/<slug>-dev-loop.new.md but never said how that file gets written -- the natural reading was shell redirection, which is exactly what PR #67 documented as blocked in some sandboxes, and /tmp is outside the repo directory some sandboxes also restrict. Now names the Write tool and an in-repo scratch path, and fails closed (abort, don't overwrite unreviewed) if the write itself fails. Also updated Step 1's MODE=update bullet, which still said 'record in my-claude-skills' after PR #69 renamed Step 7 to an optional personal catalog. Closes #73
dmccoystephenson
changed the title
dmccoystephenson
added a commit
that referenced
this pull request
Aug 3, 2026
Step 7 previously assumed every user maintains a ~/a-private-repo-3 catalog repo and would hard-fail (cd into a nonexistent directory) for anyone who doesn't. Check for its existence first and skip silently when absent -- it's a personal convenience convention, not required for the generated skill to work.
dmccoystephenson
added a commit
that referenced
this pull request
Aug 3, 2026
…nce (#77) Step 1 told the generator to diff against /tmp/<slug>-dev-loop.new.md but never said how that file gets written -- the natural reading was shell redirection, which is exactly what PR #67 documented as blocked in some sandboxes, and /tmp is outside the repo directory some sandboxes also restrict. Now names the Write tool and an in-repo scratch path, and fails closed (abort, don't overwrite unreviewed) if the write itself fails. Also updated Step 1's MODE=update bullet, which still said 'record in a-private-repo-3' after PR #69 renamed Step 7 to an optional personal catalog. Closes #73
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/example-skills-catalogcatalog repo and unconditionallycds into it — for anyone without that repo, this would hard-fail generation right after Steps 1-6 already did real work (GitHub repo created, labels seeded, slash command registered).[ -d ~/example-skills-catalog/.git ]first. If present, records the skill as before. If absent, skips silently — Step 5 already registered the slash command, so the generated skill is fully functional without a catalog entry.Why
Flagged during OSS-readiness review:
~/local-skills/(Steps 1/3/5) already degrades gracefully viamkdir -p, but~/example-skills-catalog/(Step 7) did not. This was the one remaining hard external-contributor blocker from the OSS-prep audit.Test plan
python3 scripts/check_docs.pypasses{{placeholder}}introduceddrafted by Claude on behalf of Daniel Stephenson