Fix Step 1 update-mode scratch file and stale example-skills-catalog reference - #77
Merged
Merged
Conversation
Step 1 told the generator to diff against /tmp/<slug>-dev-loop.new.md but never said how that file gets written -- the natural reading was shell redirection, which is exactly what PR #67 documented as blocked in some sandboxes, and /tmp is outside the repo directory some sandboxes also restrict. Now names the Write tool and an in-repo scratch path, and fails closed (abort, don't overwrite unreviewed) if the write itself fails. Also updated Step 1's MODE=update bullet, which still said 'record in my-claude-skills' after PR #69 renamed Step 7 to an optional personal catalog. Closes #73
dmccoystephenson
added a commit
that referenced
this pull request
Aug 3, 2026
…nce (#77) Step 1 told the generator to diff against /tmp/<slug>-dev-loop.new.md but never said how that file gets written -- the natural reading was shell redirection, which is exactly what PR #67 documented as blocked in some sandboxes, and /tmp is outside the repo directory some sandboxes also restrict. Now names the Write tool and an in-repo scratch path, and fails closed (abort, don't overwrite unreviewed) if the write itself fails. Also updated Step 1's MODE=update bullet, which still said 'record in a-private-repo-3' after PR #69 renamed Step 7 to an optional personal catalog. Closes #73
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/tmp/<slug>-dev-loop.new.mdwithout ever saying how that file is produced. The natural reading was shell>redirection into/tmp-- exactly the pattern PR Add Tests-fix CI-revert fallback ladder and scratch-file guidance #67 documented as blocked in some harness sandboxes, and/tmpis outside the repo directory some sandboxes restrict even when in-repo writes succeed. If the scratch write silently failed, the pre-overwrite diff -- the only confirmation gate protecting an existing skill file -- could be skipped.Writetool as the mechanism, uses an in-repo scratch path (~/local-skills/<slug>-dev-loop/<slug>-dev-loop.md.new), and fails closed -- abort and report rather than overwrite without having shown the diff -- if the scratch write fails. Cleans up withpython3 -c "import os; os.remove(path)"rather thanrm, matching PR Add Tests-fix CI-revert fallback ladder and scratch-file guidance #67's rationale.example-skills-catalog" after PR Make example-skills-catalog catalog recording optional #69 renamed Step 7 to an optional personal catalog and made it conditional on the directory existing.Closes #73
Note on scope
create-dev-loop.mdis on the do-not-auto-merge list -- issue #73 explicitly flagged that this needs human review before merge and validation via aMODE=updateend-to-end run perCLAUDE.md's "Testing changes" item 5. Opening under the maintainer's direct, in-session request to polish the repo.Research grounding
No
RESEARCH.mdfinding applies -- this is the same class of harness/sandbox operational observation PR #67 explicitly declined to force a citation for (matches issue #73's own assessment).Test plan
python3 scripts/check_docs.pypasses{{placeholder}}added or changed; no Step count/numbering changeMODE=updateend-to-end dry run against a fixture repo with an existing generated skill was not performed. This session has no fixture repo with a pre-existing<slug>-dev-loopskill to update against, and the sandbox restricts filesystem writes outside this repo's own working directory (the same constraint this PR documents). The change is prose-only inside an existing Step (no placeholders, no fence/escaping changes, no Step renumbering), which lowers risk, but a maintainer with a real fixture should confirmMODE=updatestill produces a reviewable diff and correctly cleans up the scratch file before treating this as fully verified.drafted by Claude on behalf of Daniel Stephenson