Repository navigation
fix: close local CI parity gaps and deduplicate TypeScript builds - #385
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make ciomitted dependency audit, site/ADR checks and exported JSDoc, while the TypeScript job emitted every workspace three times and reran tests for discarded coverage. Share the JSDoc change selector, add the missing local gates, and build once before type checking and testing the built output.Local Go lint now verifies version 2.12.2 and follows CI's whole-code security/correctness plus changed-line revive policy. Full documentation audits remain available for #217. Invalid bases and untracked Go files fail explicitly. Checkout-specific caches prevent cached absolute finding paths from silently dropping documentation failures across worktrees. Standalone check/test commands remain build-safe.
Fixes #265 (mandatory items 1–6). Biome schema/range/lockfile already agree on 2.5.12; optional Dependabot grouping remains deferred pending triage preference. Action pins, workflow permissions and hosted security gates are unchanged.
Verification
pnpm install --frozen-lockfileand correctedmake ci CI_BASE=9a495bc404a6f2dde67b34e72409a909d2964dd1pass, including full Go tests, dependency/vulnerability scans, 177 workspace tests and 132 script tests.pnpm --recursive check && pnpm test && pnpm lintpasses.actionlintandgit diff --checkpass.80a6efe. The TypeScript job confirms three emitting compiler invocations total (one per workspace), down from nine. Final evidence-only head checks are reflected below by GitHub.See
docs/CI_PARITY_2026_10_15.mdfor baseline comparison, scope and evidence. GitHub-only service checks remain separate from local parity.Merge resolution
PASSED: merged normally as
ba28f9c0b33c2366ccb892c2cf5bc33dcf792600on 2026-10-15. Issue #265 closed on merge.The blocker was cleared by rerunning the canceled duplicate CI run 38783982642, which originally stopped before creating any jobs on reviewed head
115de6b9beb95116ed8b8b30ad267279de681da8. A successful sibling run made the visible check rollup green while merge state remained BLOCKED. Attempt 2 passed all applicable CI gates and GitHub changed the merge state to CLEAN, without any code or policy changes.The normal squash merge was pinned to the verified head. Branch-protection and active-rules API snapshots were identical before and after the merge; administrator enforcement and required checks remain intact. Independent review was Ready on attempt 2 of 3. Existing #217 documentation debt and optional Dependabot grouping remain deferred.