Skip to content

fix: close local CI parity gaps and deduplicate TypeScript builds - #385

Merged
dills122 merged 3 commits into
mainfrom
codex/ci-parity-265
Oct 15, 2026
Merged

dills122 merged 3 commits into
mainfrom
codex/ci-parity-265

Conversation

@dills122

@dills122 dills122 commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

make ci omitted dependency audit, site/ADR checks and exported JSDoc, while the TypeScript job emitted every workspace three times and reran tests for discarded coverage. Share the JSDoc change selector, add the missing local gates, and build once before type checking and testing the built output.

Local Go lint now verifies version 2.12.2 and follows CI's whole-code security/correctness plus changed-line revive policy. Full documentation audits remain available for #217. Invalid bases and untracked Go files fail explicitly. Checkout-specific caches prevent cached absolute finding paths from silently dropping documentation failures across worktrees. Standalone check/test commands remain build-safe.

Fixes #265 (mandatory items 1–6). Biome schema/range/lockfile already agree on 2.5.12; optional Dependabot grouping remains deferred pending triage preference. Action pins, workflow permissions and hosted security gates are unchanged.

Verification

  • pnpm install --frozen-lockfile and corrected make ci CI_BASE=9a495bc404a6f2dde67b34e72409a909d2964dd1 pass, including full Go tests, dependency/vulnerability scans, 177 workspace tests and 132 script tests.
  • Requested pnpm --recursive check && pnpm test && pnpm lint passes.
  • Focused regressions: 18/18; real golangci-lint integration: 4/4, including repeated checks of two retained checkout roots sharing a cache parent.
  • actionlint and git diff --check pass.
  • Required unfiltered Go lint retains the known quality: enforce exported contract documentation #217 revive backlog (50 reported under the output cap); the scoped CI gates pass. No claim that full documentation debt is resolved.
  • Independent review attempt 1 found the cross-checkout cache defect; fresh independent review attempt 2 returned Ready with no remaining actionable findings. Hosted CI and both CodeQL analyses passed on implementation commit 80a6efe. The TypeScript job confirms three emitting compiler invocations total (one per workspace), down from nine. Final evidence-only head checks are reflected below by GitHub.

See docs/CI_PARITY_2026_10_15.md for baseline comparison, scope and evidence. GitHub-only service checks remain separate from local parity.

Merge resolution

PASSED: merged normally as ba28f9c0b33c2366ccb892c2cf5bc33dcf792600 on 2026-10-15. Issue #265 closed on merge.

The blocker was cleared by rerunning the canceled duplicate CI run 38783982642, which originally stopped before creating any jobs on reviewed head 115de6b9beb95116ed8b8b30ad267279de681da8. A successful sibling run made the visible check rollup green while merge state remained BLOCKED. Attempt 2 passed all applicable CI gates and GitHub changed the merge state to CLEAN, without any code or policy changes.

The normal squash merge was pinned to the verified head. Branch-protection and active-rules API snapshots were identical before and after the merge; administrator enforcement and required checks remain intact. Independent review was Ready on attempt 2 of 3. Existing #217 documentation debt and optional Dependabot grouping remain deferred.

@dills122
dills122 marked this pull request as ready for review October 15, 2026 18:16
@dills122
dills122 merged commit ba28f9c into main Oct 15, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

task: close make ci / GitHub Actions parity gap and dedupe TS build/test steps

1 participant