fix #454: guard against None in PlotCollection.__getattr__ to prevent TypeError - #456
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix #454: guard against None in PlotCollection.__getattr__ to prevent TypeError#456cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…otCollection.__getattr__ When PlotBase.get_attribute_helper() returns None (e.g. due to partial import failures in stereo/plots/__init__.py), the code was wrapping None with the download decorator. This created a callable wrapper that crashed with TypeError: 'NoneType' object is not callable when invoked. The fix checks for None immediately after get_attribute_helper() returns, raising a clear AttributeError instead of silently wrapping None. Co-authored-by: wanruiwen-genomics-cn <wanruiwen-genomics-cn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
PlotBase.get_attribute_helper()returnsNone(e.g., due to partial import failures instereo/plots/__init__.pypreventing plot subclasses from being registered), thePlotCollection.__getattr__method was wrappingNonewith thedownloaddecorator. This created a callable wrapper that, when invoked, tried to callNone(*args, **kwargs), producing the confusingTypeError: 'NoneType' object is not callableerror reported in #454.Changes
stereo/plots/plot_collection.py: Added an explicitNonecheck on the return value ofget_attribute_helper()before thedownloaddecorator is applied. When the resolved function isNone, a clearAttributeErroris raised immediately instead of wrappingNone.tests/test_plot_collection_getattr.py: Added tests validating that:Noneguard exists in the source and comes beforedownload(new_attr)AttributeErrorforNonewhile the buggy logic would wrap itdownloaddecorator wrappingNoneproduces the reportedTypeErrorVerification
__getattr__control flow was modifiedClassification
Closes #454