Skip to content

fix: revoke superseded active deploy grants - #8

Merged
JuaniRios merged 1 commit into
mainfrom
app-release-revoke-superseded-grant
Sep 14, 2026
Merged

JuaniRios merged 1 commit into
mainfrom
app-release-revoke-superseded-grant

Conversation

@JuaniRios

@JuaniRios JuaniRios commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

  • A completed production release can leave its Privileged Access Manager grant active when cleanup cannot revoke it.
  • A later release then fails before requesting a new approval because the old justification differs.

Solution

  • Reuse an open grant only when its justification matches the same deployment.
  • Revoke a superseded ACTIVE grant before requesting a fresh grant with the new deployment details.
  • Keep grants that still await approval under human control.
  • Add tests for both paths.
  • Fail before requesting a replacement if the releaser cannot revoke the superseded grant.

Checks

By submitting this for review, I'm confirming I've done the following:

  • added comprehensive test coverage for any changes in logic
  • made this PR as small as possible
  • linked any relevant issues or PRs
  • included screenshots (not applicable)

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@JuaniRios JuaniRios changed the title app-release: revoke superseded active grant fix: revoke superseded active deploy grants Sep 14, 2026
@JuaniRios
JuaniRios marked this pull request as ready for review September 14, 2026 19:55
@JuaniRios
JuaniRios merged commit 719cba4 into main Sep 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant