Skip to content

fix: reuse open app-deploy grants - #9

Merged
JuaniRios merged 1 commit into
mainfrom
fix/reuse-open-pam-grants
Sep 14, 2026
Merged

JuaniRios merged 1 commit into
mainfrom
fix/reuse-open-pam-grants

Conversation

@JuaniRios

@JuaniRios JuaniRios commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

  • The revoke path added in fix: revoke superseded active deploy grants #8 fails because the app releaser does not have the revoke permission.
  • We need the current liquidity config rollout. We will fix the Privileged Access Manager permissions separately.

Solution

  • Reuse any active or pending app-deploy grant without comparing its justification.
  • Remove the grant replacement and revoke path.
  • Cover both ACTIVE and APPROVAL_AWAITED grant reuse in the workflow tests.
  • A release can temporarily use a grant approved for a different earlier release while that grant remains open.

Checks

By submitting this for review, I'm confirming I've done the following:

  • added comprehensive test coverage for any changes in logic
  • made this PR as small as possible
  • linked any relevant issues or PRs
  • included screenshots (not applicable)

@JuaniRios JuaniRios changed the title app-release: reuse open PAM grants fix: reuse open app-deploy grants Sep 14, 2026
@JuaniRios
JuaniRios marked this pull request as ready for review September 14, 2026 20:11

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@JuaniRios
JuaniRios merged commit 0780aef into main Sep 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant