Repository navigation
Fix model selection for firmware-specific configurations - #120
Open
Michi-Tsubaki wants to merge 1 commit into
Open
Michi-Tsubaki wants to merge 1 commit into
Michi-Tsubaki wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why ?
Firmware-specific model files such as _fw52.model describe the control table for firmware versions up to and including 52. Previously, the selection logic treated the suffix as a lower bound. Devices running firmware below 52 could therefore select the base model file and use incorrect Indirect Data addresses.
Changes
Select the smallest firmware suffix greater than or equal to the device firmware version.
For models with an _fw52.model file, firmware versions 1–52 now use that file, while firmware 53 and later continue to use the base model file.
Backward compatibility
Existing fallback behavior is preserved. Unknown firmware (0), models without firmware-specific files, and firmware newer than all available suffixes continue to use the base model file. Firmware 52 still selects _fw52.model.
No public APIs or model file formats are changed.