Dependency Constant Version Tables#685
Draft
uniboi wants to merge 6 commits into
Draft
Conversation
Member
|
Oooh, I like this a lot :D I assume the commented out code is still planned to be cleaned up? ^^ |
Co-authored-by: GeckoEidechse <40122905+GeckoEidechse@users.noreply.github.com>
catornot
requested changes
Apr 6, 2024
Member
There was a problem hiding this comment.
your semver parser crashed :|
patch is empty and minor has a .

no stack trace in logs
mods that made it crash : live holo & holo mimic
it crashed at CreateSlot("patch", stoi(patch)); btw
Member
|
I guess this needs a preliminary check if mod version is even properly formatted and fail out if not? |
Member
|
@uniboi bump |
Member
|
Converting to draft until merge conflicts are addressed. cc @uniboi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0major,minorandpatchkeys for the versions of the mod1.x.xwould only expose themajorkey