Add support for ScriptFile and GlobalFunction dependencies#923
Conversation
|
what's the motivation behind this? seems kind of pointless when instead mod versions could be provided #685 |
|
Worth mentioning that this approach will also break all existing mods that use dependency constants |
|
so you want it to make sure a function, added by a mod exists? |
|
If you want to target different versions of northstar or some mods, the versioned dependencies pr should be revived instead. If it's not enough, I think this implementation is not generic enough, since it only considers exposed functions by northstar and init functions for mods. hooking into the squirrel compiler should be the actual solution for this. |
|
Possibly a better way of implementing this could be to implement shouldn't be too hard i think? the |
|
as a bit of an example of what I was thinking: I'm guessing If global functions could be added to the consttable then this could work |
I just went ahead and built it as soon as the idea came to me, so I honestly didn’t give those points much thought at the time. |
|
You didn't have to close this pr, the pr just needs a few improvements :) |
No description provided.