Disable /rw/config/rc.local-early if custom-persist is enabled - #667
Merged
Conversation
Custom-persist feature is supposed to disable using files out of /rw except explicitly enabled. Initial commit handled /rw/config/rc.local, but missed /rw/config/rc.local-early. Fix it now. While this allows bypassing custom-persist feature, it isn't considered security issue, only functional issue. See documentation for details: https://doc.qubes-os.org/en/r4.3/user/templates/templates.html#note-on-treating-app-qubes-root-filesystem-non-persistence-as-a-security-feature For secure non-persistent qubes, the correct approach is to use a disposable, which eliminates way more way more potential persistence methods (including attacking kernel filesystem driver for example). Reported-by: Thiago Pereira (@B1gN0Se) via SecureDrop bug bounty QubesOS/qubes-issues#1006
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #667 +/- ##
==========================================
+ Coverage 71.31% 71.71% +0.39%
==========================================
Files 3 3
Lines 502 502
==========================================
+ Hits 358 360 +2
+ Misses 144 142 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Aug 9, 2026
Open
Open
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026080820-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests8 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 32 fixed
Unstable testsDetails
Performance TestsPerformance degradation:18 performance degradations
Remaining performance tests:93 tests
|
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom-persist feature is supposed to disable using files out of /rw
except explicitly enabled. Initial commit handled /rw/config/rc.local,
but missed /rw/config/rc.local-early. Fix it now.
While this allows bypassing custom-persist feature, it isn't considered
security issue, only functional issue. See documentation for details:
https://doc.qubes-os.org/en/r4.3/user/templates/templates.html#note-on-treating-app-qubes-root-filesystem-non-persistence-as-a-security-feature
For secure non-persistent qubes, the correct approach is to use a
disposable, which eliminates way more way more potential persistence
methods (including attacking kernel filesystem driver for example).
Reported-by: Thiago Pereira (@B1gN0Se) via SecureDrop bug bounty
QubesOS/qubes-issues#1006