Use admin utils wrappers for vm actions - #212
Conversation
|
Still didn't test locally, but the main PR to core-admin-client and another very similar PR QubesOS/qubes-desktop-linux-manager@47565a5, were tested by openqa on https://openqa.qubes-os.org/tests/180820, and they did pass, so marking this PR as ready for review. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
==========================================
- Coverage 71.72% 71.37% -0.36%
==========================================
Files 12 12
Lines 1337 1331 -6
==========================================
- Hits 959 950 -9
- Misses 378 381 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026080611-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests14 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 30 fixed
Unstable testsDetails
Performance TestsPerformance degradation:19 performance degradations
Remaining performance tests:92 tests
|
| self.logger.info('Shutdown %s', self.qube.name) | ||
| self.qube.shutdown() | ||
| wait = True | ||
| asyncio.run(shutdown_domains([self.qube], self.logger, wait=wait)) |
There was a problem hiding this comment.
Simply self.qube.shutdown(wait=wait) here, since it has wait option now?
There was a problem hiding this comment.
I will push changes that resolve the merge conflict, and then will test if a freezed domain that tries to shutdown, will hang the progress of other qubes.
There was a problem hiding this comment.
Testcase, log "SLEEP" and sleep before that part, tail -F /var/log/qubes/update-QUBE.log, start update for 3 domains, max concurrency of 2 and try to update. Freeze the qube when it's sleeping. Notice the update of the 3rd qube continue, so it's not freezing everything.
The difference is that that with my code, the exception message only appears in the logs, while with your proposal, it appears on the console. I think your proposal is correct. I think that a combination of these solutions are correct in this case, because it should be logged to both places and raised on the console.
17dd664 to
522c046
Compare
522c046 to
19d64ca
Compare
|
now it has some conflicts (likely due to type hints) |
4 participants
Please see: QubesOS/qubes-core-admin-client#469 (comment)
Didn't test locally, only know that unit tests pass.