q-dev: fix and unify device detach on frontend shutdown - #60
Merged
Conversation
When a frontend qube with an attached device is shut down, the detach event should be fired Use common parts from utils. Add tests
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026080611-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests14 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 30 fixed
Unstable testsDetails
Performance TestsPerformance degradation:19 performance degradations
Remaining performance tests:92 tests
|
This was referenced Jul 20, 2026
Merged
Member
The above looks to be related to this PR. |
This was referenced Jul 29, 2026
marmarek
reviewed
Jul 31, 2026
| # notify that they are gone and detach them from frontend vms | ||
| utils.device_list_change(self, {}, vm, None, USBDevice) | ||
| # devices attached to shutting-down frontend vm: notify detach | ||
| utils.detach_attached_devices_on_shutdown(self, vm, USBDevice) |
Member
There was a problem hiding this comment.
Note to self: this needs relevant core-admin change uploaded to R4.3, and appropriate package dependency set.
This was referenced Jul 31, 2026
Merged
Merged
Merged
Merged
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a frontend qube with an attached device is shut down, the detach event should be fired Use common parts from utils.
Add tests
requires: QubesOS/qubes-core-admin/pull/843