sftp: Introduce ssh_mode: native, using golang's ssh module#56
Open
glemmaPaul wants to merge 2 commits into
Open
sftp: Introduce ssh_mode: native, using golang's ssh module#56glemmaPaul wants to merge 2 commits into
glemmaPaul wants to merge 2 commits into
Conversation
common/e2e_test: Add tests for both openssh and native mode to be aligned
omar-polo
approved these changes
Jul 7, 2026
omar-polo
left a comment
omar-polo
left a comment
Collaborator
There was a problem hiding this comment.
haven't tested it on windows yet, but LGTM :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a parameter (not included in schema.json)
ssh_modethat defaults toopensshbut moves tonativeif set orGOOSiswindows. Whennativeis chosen, golang's ssh module is used, aligning as close to theopensshsidecar solution.Includes test (especially
e2e_test.go) that test the commonality between the twossh_mode. It specifically spins up a docker (very AI generated bloatcode, mi scusi) with atmoz/sftp to completely test end to end.