Fix #54: remove dependency on SSH multiplexing and the auth socket no…#61
Open
MorphiX00 wants to merge 1 commit into
Open
Fix #54: remove dependency on SSH multiplexing and the auth socket no…#61MorphiX00 wants to merge 1 commit into
MorphiX00 wants to merge 1 commit into
Conversation
… socket not supported on Windows
Collaborator
Author
|
Indeed, but apparently the issue is not handled in the same way. I think this PR could be a good quick fix since it requires relatively few changes to the existing code. Then, later on, you could consider integrating the native ssh_mode of the PR #56 . It would also be interesting to compare the performance of the OpenSSH implementation with the native ssh_mode implementation. Another advantage of the native ssh_mode is that it would not depend on the OpenSSH binary, making it potentially compatible with older versions of Windows without requiring OpenSSH to be installed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the dependency on SSH multiplexing and the SSH auth socket, which are not supported on Windows.
Changes
Related to #54