Skip to content

Fix #54: remove dependency on SSH multiplexing and the auth socket no…#61

Open
MorphiX00 wants to merge 1 commit into
PlakarKorp:integration/sftpfrom
MorphiX00:integration/sftp
Open

Fix #54: remove dependency on SSH multiplexing and the auth socket no…#61
MorphiX00 wants to merge 1 commit into
PlakarKorp:integration/sftpfrom
MorphiX00:integration/sftp

Conversation

@MorphiX00

Copy link
Copy Markdown

Summary

This PR removes the dependency on SSH multiplexing and the SSH auth socket, which are not supported on Windows.

Changes

  • Remove the SSH multiplexing dependency on Windows.
  • Remove the dependency on the SSH auth socket on Windows.

Related to #54

@omar-polo

Copy link
Copy Markdown
Collaborator

Hello,

Thanks for the PR for this but... there was already #56 pending 😅. I'll take a closer look at this to compare to #56 later today though.

Thanks!

@MorphiX00

Copy link
Copy Markdown
Author

Indeed, but apparently the issue is not handled in the same way. I think this PR could be a good quick fix since it requires relatively few changes to the existing code. Then, later on, you could consider integrating the native ssh_mode of the PR #56 .

It would also be interesting to compare the performance of the OpenSSH implementation with the native ssh_mode implementation.

Another advantage of the native ssh_mode is that it would not depend on the OpenSSH binary, making it potentially compatible with older versions of Windows without requiring OpenSSH to be installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants