Skip to content

Register lowering for conv_fwd_jvp_p and conv_bwd_jvp_p #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbharadwaj-bk merged 3 commits into from
Mar 6, 2026
Merged

Register lowering for conv_fwd_jvp_p and conv_bwd_jvp_p #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4fd738f
register lowering for conv_fwd_jvp_p and conv_bwd_jvp_p
teddykoker Mar 6, 2026
bad6b82
prek -a
teddykoker Mar 6, 2026
e795961
add tp too
teddykoker Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions openequivariance/openequivariance/jax/jvp/conv_prim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,16 @@ def conv_fwd_jvp_abstract_eval(

conv_fwd_jvp_p.def_impl(conv_fwd_jvp_impl)
conv_fwd_jvp_p.def_abstract_eval(conv_fwd_jvp_abstract_eval)
mlir.register_lowering(
conv_fwd_jvp_p,
mlir.lower_fun(conv_fwd_jvp_impl, multiple_results=False),
platform="cuda",
)
mlir.register_lowering(
conv_fwd_jvp_p,
mlir.lower_fun(conv_fwd_jvp_impl, multiple_results=False),
platform="rocm",
)


# ==============================================================================
Expand Down Expand Up @@ -285,6 +295,16 @@ def conv_bwd_jvp_abstract_eval(

conv_bwd_jvp_p.def_impl(conv_bwd_jvp_impl)
conv_bwd_jvp_p.def_abstract_eval(conv_bwd_jvp_abstract_eval)
mlir.register_lowering(
conv_bwd_jvp_p,
mlir.lower_fun(conv_bwd_jvp_impl, multiple_results=True),
platform="cuda",
)
mlir.register_lowering(
conv_bwd_jvp_p,
mlir.lower_fun(conv_bwd_jvp_impl, multiple_results=True),
platform="rocm",
)


# ==============================================================================
Expand Down
21 changes: 20 additions & 1 deletion openequivariance/openequivariance/jax/jvp/tp_prim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,16 @@ def tp_fwd_jvp_abstract_eval(X, Y, W, dX, dY, dW, *, L3_dim, kernel, hash):

tp_fwd_jvp_p.def_impl(tp_fwd_jvp_impl)
tp_fwd_jvp_p.def_abstract_eval(tp_fwd_jvp_abstract_eval)
mlir.register_lowering(
tp_fwd_jvp_p,
mlir.lower_fun(tp_fwd_jvp_impl, multiple_results=False),
platform="cuda",
)
mlir.register_lowering(
tp_fwd_jvp_p,
mlir.lower_fun(tp_fwd_jvp_impl, multiple_results=False),
platform="rocm",
)


# ==============================================================================
Expand Down Expand Up @@ -225,7 +235,16 @@ def tp_bwd_jvp_abstract_eval(X, Y, W, dZ, tX, tY, tW, tdZ, *, kernel, hash):

tp_bwd_jvp_p.def_impl(tp_bwd_jvp_impl)
tp_bwd_jvp_p.def_abstract_eval(tp_bwd_jvp_abstract_eval)

mlir.register_lowering(
tp_bwd_jvp_p,
mlir.lower_fun(tp_bwd_jvp_impl, multiple_results=True),
platform="cuda",
)
mlir.register_lowering(
tp_bwd_jvp_p,
mlir.lower_fun(tp_bwd_jvp_impl, multiple_results=True),
platform="rocm",
)

# ==============================================================================
# 9. Transpose Rule for Backward JVP
Expand Down