Skip to content

Register lowering for conv_fwd_jvp_p and conv_bwd_jvp_p#190

Merged
vbharadwaj-bk merged 3 commits intoPASSIONLab:mainfrom
teddykoker:main
Mar 6, 2026
Merged

Register lowering for conv_fwd_jvp_p and conv_bwd_jvp_p#190
vbharadwaj-bk merged 3 commits intoPASSIONLab:mainfrom
teddykoker:main

Conversation

@teddykoker
Copy link
Copy Markdown
Contributor

Fixes #189. Think these are just missing?

vbharadwaj-bk
vbharadwaj-bk previously approved these changes Mar 6, 2026
Copy link
Copy Markdown
Member

@vbharadwaj-bk vbharadwaj-bk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks great. Running CI and merging.

@vbharadwaj-bk vbharadwaj-bk added ci-ready Triggers CI checks for a pull request and removed ci-ready Triggers CI checks for a pull request labels Mar 6, 2026
@vbharadwaj-bk
Copy link
Copy Markdown
Member

vbharadwaj-bk commented Mar 6, 2026

Ah, ruff failed - would you mind running

pip install pre-commit
pre-commit run --all-files

inside the repo

@vbharadwaj-bk vbharadwaj-bk dismissed their stale review March 6, 2026 03:41

Looks great but need pre-commit

@vbharadwaj-bk vbharadwaj-bk added the ci-ready Triggers CI checks for a pull request label Mar 6, 2026
Copy link
Copy Markdown
Member

@vbharadwaj-bk vbharadwaj-bk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbharadwaj-bk vbharadwaj-bk added ci-ready Triggers CI checks for a pull request and removed ci-ready Triggers CI checks for a pull request labels Mar 6, 2026
@vbharadwaj-bk vbharadwaj-bk merged commit c6ba580 into PASSIONLab:main Mar 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-ready Triggers CI checks for a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JAX JVP fails if not wrapped by grad

2 participants