Chore/cleanup ux palette refactor

[MohamedAklamaash]

🧾 High-Level Summary

This PR adds GitHub OAuth/login, repo access control, private-repo ingestion, SSE chat streaming, graph/file auth gating, and a major frontend UI/routing refactor. Overall code health is mixed: the feature set is substantial and fairly well-covered by tests, but there are a few security and correctness risks around auth flows, token handling, and caching.

🚨 Critical Issues (Must Fix)

• logout/session auth flow is only as strong as CSRF handling; the custom CSRF-exempt session auth for logout is risky and should be tightly constrained and reviewed for accidental reuse.
• OAuth and GitHub token handling now touches encrypted credentials, reauth flags, and GitHub probing; any failure path that logs or returns sensitive error details should be audited to ensure secrets never leak.
• Repo access enforcement is broad but highly coupled across apps; a missed route or stale cache entry could still expose repo data if not consistently guarded.

⚠️ Warnings (Should Fix)

• RepositoryAccess + is_private introduce more branchy access logic; the private/public inference and reauth behavior needs careful edge-case review for 401/403/404 consistency.
• Several new frontend API paths rely on backend error codes (needs_reauth, no_access, github_unreachable, etc.); mismatches will produce confusing UX.
• The SSE chat implementation and streaming state handling are more complex than the prior request/response flow and should be watched for partial-response and abort edge cases.
• The new cache-backed repo/repo-list behavior may serve stale data if invalidation is incomplete.

💡 Suggestions (Nice to Have)

• Add integration tests for token decryption failure, logout CSRF boundaries, and GitHub probe/rate-limit edge cases.
• Centralize repo-access error mapping so backend and frontend stay in sync.
• Consider splitting the large repos/views.py and chat/views.py changes into smaller service modules for maintainability.
• Revisit frontend state restoration and router behavior for deep links and reloads.

🔐 Security Verdict

Risky — the PR improves access control and credential handling overall, but it also introduces sensitive OAuth/token paths, custom auth behavior, and broader cache-driven repo gating that need careful hardening.

📊 Final PR Rating

4/5 — strong feature work with good test coverage and meaningful security improvements, but not production-ready without a closer audit of auth/token edge cases and cache/invalidation behavior.

📝 Suggested Prompt Update

The prompt is missing a way to handle PRs where the base branch has no merge base in the sandbox. It should ask for either:

• a commit-by-commit summary from git show --stat --summary <commit>, or
• a pasted commit list/message set from the user,
  when git diff main...HEAD is unavailable.

It also needs a fallback instruction for “per-commit review” when only a flattened change summary is available:

• clearly state that individual commit ratings cannot be verified from the provided data,
• and provide a best-effort chronological risk trend based on the available summaries.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c6a4ec55-567f-492a-ad2e-8a1486b638b5

📥 Commits

Reviewing files that changed from the base of the PR and between 982dc2d and 60a4813.

⛔ Files ignored due to path filters (4)

• demo/graph.png is excluded by !**/*.png
• frontend/package-lock.json is excluded by !**/package-lock.json
• frontend/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
• frontend/public/favicon.svg is excluded by !**/*.svg

📒 Files selected for processing (70)

• .gitignore
• backend/apps/auth_github/__init__.py
• backend/apps/auth_github/apps.py
• backend/apps/auth_github/crypto.py
• backend/apps/auth_github/github_api.py
• backend/apps/auth_github/migrations/0001_initial.py
• backend/apps/auth_github/migrations/__init__.py
• backend/apps/auth_github/models.py
• backend/apps/auth_github/tests/__init__.py
• backend/apps/auth_github/tests/test_crypto.py
• backend/apps/auth_github/tests/test_github_api.py
• backend/apps/auth_github/tests/test_github_repos_view.py
• backend/apps/auth_github/tests/test_oauth_callback.py
• backend/apps/auth_github/urls.py
• backend/apps/auth_github/views.py
• backend/apps/chat/views.py
• backend/apps/embeddings/client.py
• backend/apps/files/views.py
• backend/apps/graph/views.py
• backend/apps/repos/_view_helpers.py
• backend/apps/repos/migrations/0002_repository_first_ingested_by_repository_is_private_and_more.py
• backend/apps/repos/migrations/0003_alter_repository_status.py
• backend/apps/repos/models.py
• backend/apps/repos/tasks.py
• backend/apps/repos/tests/__init__.py
• backend/apps/repos/tests/conftest.py
• backend/apps/repos/tests/test_attach.py
• backend/apps/repos/tests/test_cross_app_gating.py
• backend/apps/repos/tests/test_cross_repo_idor.py
• backend/apps/repos/tests/test_redact.py
• backend/apps/repos/tests/test_repository_view.py
• backend/apps/repos/tests/test_view_helpers.py
• backend/apps/repos/urls.py
• backend/apps/repos/utils.py
• backend/apps/repos/views.py
• backend/conftest.py
• backend/core/settings.py
• backend/core/test_settings.py
• backend/core/test_urls.py
• backend/core/urls.py
• backend/env.local
• backend/manage.py
• backend/pytest.ini
• backend/requirements.txt
• docker-compose.yml
• frontend/index.html
• frontend/local.env
• frontend/package.json
• frontend/src/App.tsx
• frontend/src/api/index.ts
• frontend/src/auth/AuthContext.tsx
• frontend/src/components/AskPalette.tsx
• frontend/src/components/ChatPanel.tsx
• frontend/src/components/Dashboard.tsx
• frontend/src/components/GithubRepoPicker.tsx
• frontend/src/components/GraphPanel.tsx
• frontend/src/components/Landing.tsx
• frontend/src/components/Login.tsx
• frontend/src/components/Processing.tsx
• frontend/src/components/RepoSwitcher.tsx
• frontend/src/components/Sidebar.tsx
• frontend/src/components/ThemeToggle.tsx
• frontend/src/constants/repoStatus.ts
• frontend/src/hooks/useChat.ts
• frontend/src/hooks/useMediaQuery.ts
• frontend/src/index.css
• frontend/src/main.tsx
• frontend/src/theme.ts
• frontend/src/types/index.ts
• frontend/vite.config.js

---

📝 Walkthrough

Walkthrough

Adds GitHub OAuth login, encrypted identity storage, repository access probing and ingestion, repo-scoped chat/graph/file enforcement, and a routed frontend with streaming chat, GitHub repo selection, and theme/auth state.

Changes

GitHub auth, repo access, and streaming UI

Layer / File(s)	Summary
Runtime and test bootstrap .gitignore, backend/conftest.py, backend/core/{settings.py,test_settings.py,test_urls.py,urls.py}, backend/env.local, backend/manage.py, backend/pytest.ini, backend/requirements.txt, docker-compose.yml, frontend/{index.html,local.env,package.json,vite.config.js}	Local dev, test, and container settings now use the new ports and defaults, and the ignore list covers the expanded Python, Node, cache, and editor artifacts.
GitHub identity helpers backend/apps/auth_github/{apps.py,crypto.py,github_api.py,models.py,migrations/0001_initial.py}, backend/apps/auth_github/tests/{test_crypto.py,test_github_api.py}	Adds the GitHubIdentity model, Fernet token helpers, reauth helpers, and tests for token round-trips and GitHub request mapping.
GitHub OAuth endpoints backend/apps/auth_github/{urls.py,views.py}, backend/apps/auth_github/tests/{test_oauth_callback.py,test_github_repos_view.py}	Implements GitHub OAuth start/callback, logout, CSRF, me, and repo-list endpoints with tests for callback validation, identity creation, and repo responses.
Repository schema and helpers backend/apps/repos/{_view_helpers.py,models.py,utils.py,migrations/*}, backend/apps/repos/tests/test_view_helpers.py	Introduces repository status enums, access metadata, URL helpers, and tests for the new repository helper and enum contracts.
Repository submission and ingestion backend/apps/repos/{urls.py,tasks.py,views.py}, backend/apps/repos/tests/{conftest.py,test_repository_view.py,test_attach.py,test_redact.py}	Reworks repository submission and attachment around URL normalization, GitHub probing, access rows, and privacy-aware ingestion, with tests for access, normalization, and redaction.
Repo-scoped enforcement backend/apps/{chat,files,graph,embeddings}/*.py, backend/apps/repos/tests/{test_cross_app_gating.py,test_cross_repo_idor.py}	Adds repo-access checks to chat, files, graph, and embedding paths, switches chat to SSE streaming, and tests cross-repo and cross-app gating.
Frontend auth, routing, and shared contracts frontend/src/{App.tsx,api/index.ts,auth/AuthContext.tsx,constants/repoStatus.ts,hooks/*,main.tsx,theme.ts,types/index.ts,components/{Login.tsx,ThemeToggle.tsx}}	Adds auth state, CSRF-aware API calls, theme persistence, streaming chat state, repo-status/type contracts, and a routed auth shell.
Frontend workspace and presentation frontend/src/components/{AskPalette.tsx,ChatPanel.tsx,Dashboard.tsx,GithubRepoPicker.tsx,GraphPanel.tsx,Landing.tsx,Processing.tsx,RepoSwitcher.tsx,Sidebar.tsx}, frontend/src/index.css	Builds the repo-selection and analysis workspace UI, including GitHub repo picking, streaming chat, graph focus, processing retry, responsive layouts, and updated styling.

Sequence Diagram(s)

OAuth login flow

sequenceDiagram
  participant Frontend
  participant GithubOAuthStartView
  participant GitHub
  participant GithubOAuthCallbackView
  participant User
  participant GitHubIdentity
  Frontend->>GithubOAuthStartView: GET /auth/github/start/
  GithubOAuthStartView->>Frontend: authorization URL and state
  Frontend->>GithubOAuthCallbackView: GET callback with code and state
  GithubOAuthCallbackView->>GitHub: exchange code and fetch user profile
  GithubOAuthCallbackView->>User: upsert user
  GithubOAuthCallbackView->>GitHubIdentity: encrypt token, store scopes, clear needs_reauth
  GithubOAuthCallbackView->>Frontend: redirect to FRONTEND_BASE_URL

Loading

Repository submission and ingest flow

sequenceDiagram
  participant Frontend
  participant RepositoryView
  participant _can_grant_access
  participant _probe_github
  participant GitHub
  participant ingest_repository
  participant Repository
  Frontend->>RepositoryView: POST /api/repos/
  RepositoryView->>_can_grant_access: normalize URL and check access
  _can_grant_access->>_probe_github: probe owner/name
  _probe_github->>GitHub: GET api.github.com/repos/{owner}/{name}
  RepositoryView->>ingest_repository: delay(repo_id, user_id)
  ingest_repository->>Repository: set status, is_private, and clone source

Loading

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~120 minutes

Poem

🐰 I hopped through GitHub gates tonight,
With tokens tucked in Fernet light.
Repos glow, the chat hops free,
Graphs and streams hum softly to me,
CodeGraph twirls—what a merry warren!

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Biome (2.5.0)

frontend/src/index.css

File contains syntax errors that prevent linting: Line 10: Tailwind-specific syntax is disabled.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}