Skip to content

ci: fix CI pipeline (pnpm frontend, ruff, lint error)#5

Merged
MohamedAklamaash merged 1 commit into
mainfrom
fix/ci-pipeline
Jun 25, 2026
Merged

ci: fix CI pipeline (pnpm frontend, ruff, lint error)#5
MohamedAklamaash merged 1 commit into
mainfrom
fix/ci-pipeline

Conversation

@MohamedAklamaash

Copy link
Copy Markdown
Owner

CI was failing on main (runs #3/#4). Two root causes, both fixed here.

1. Frontend job used npm, project uses pnpm

actions/setup-node was configured with cache: npm + cache-dependency-path: frontend/package-lock.json, but there is no package-lock.json (the repo uses pnpm-lock.yaml), so the step failed: "Some specified paths were not resolved, unable to cache dependencies." and npm ci would have failed too.

→ Switched to pnpm/action-setup@v4 + cache: pnpm + pnpm install --frozen-lockfile, and run tsc --noEmit, pnpm lint, and pnpm build. Verified the lockfile is in sync (--frozen-lockfile passes).

2. Backend lint failed on 3 pre-existing import-order issues

ruff check . reported I001 in apps/auth_github/tests/test_github_api.py, apps/repos/tasks.py, apps/repos/tests/test_view_helpers.py. Applied ruff --fix (import reordering only, no logic change).

3. Latent eslint error

Fixed @typescript-eslint/no-unused-expressions on a ternary-as-statement in Dashboard.toggle (rewrote as if/else). This wasn't caught earlier because the prior CI failed before reaching eslint.

Verified locally

  • ruff check . → clean
  • pnpm install --frozen-lockfile → up to date
  • tsc --noEmit → clean · pnpm lint → 0 errors (1 pre-existing warning) · pnpm build → clean

🤖 Generated with Claude Code

- Frontend CI used npm (cache: npm, package-lock.json, npm ci) but the
  project uses pnpm -> setup-node failed to resolve the lockfile. Switch
  to pnpm/action-setup + pnpm cache + `pnpm install --frozen-lockfile`,
  and run tsc / lint / build.
- Fix a latent eslint error: `no-unused-expressions` on a ternary-as-
  statement in Dashboard.toggle (rewrite as if/else).
- Apply ruff import-order autofix to 3 pre-existing files so
  `ruff check .` passes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@MohamedAklamaash, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 39 minutes and 22 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 829fbcd5-4c73-4e6a-be0d-5ac1e2243474

📥 Commits

Reviewing files that changed from the base of the PR and between 43c695c and 8022d44.

📒 Files selected for processing (5)
  • .github/workflows/ci.yml
  • backend/apps/auth_github/tests/test_github_api.py
  • backend/apps/repos/tasks.py
  • backend/apps/repos/tests/test_view_helpers.py
  • frontend/src/components/Dashboard.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MohamedAklamaash
MohamedAklamaash merged commit 359d821 into main Jun 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant