Add control for XIOS logging#397
Add control for XIOS logging#397Oakley Brunt (oakleybrunt) wants to merge 11 commits intoMetOffice:mainfrom
Conversation
James Bruten (james-bruten-mo)
left a comment
There was a problem hiding this comment.
rose-stem changes all fine
|
There will be a linked JEDI change to keep consistency between it and LFRic, I will link the PR once ready. |
|
Just to check, does this only affect what is in the Or will this also impact what is logged to |
|
As James Bruten (@james-bruten-mo) mentioned, the examples should have a hard-coded value for |
From a discussion with Harry Shepherd (@harry-shepherd), it shouldn't change what is in the I will run a test to double check, just so we know for sure. |
DanStoneMO
left a comment
There was a problem hiding this comment.
JEDI is all clear with this following latest change. No linked PR will be needed.
|
When When Error files stay the same: |
this is correct |
|
There is a closely related XML attribute
which defines that that logging goes to files, not to For a log level of 0 or 1, then it can be useful to send these to But for any larger values, then it is very problematic to send large volumes of essentially debug output from many ranks into As I think these could (perhaps should) be related, is it worth extending this PR to capture the setting of i think we are happy to support what do you think Oakley Brunt (@oakleybrunt) |
Hi Mark, this sounds like a good idea. I'll make the necessary changes :) |
PR Summary
Sci/Tech Reviewer:
Code Reviewer: Alistair Pirrie (@mo-alistairp)
This PR adds task-based control over the XIOS
info_level. Changes add thexios_info_leveltask option which takes an integer value. The current value forinfo_levelhas been set to 50, which produces a lot of output. The default value for the new task option is 0.Note that several apps have had
tweak_iodefadded as a default command. This is required or the env var added to the XML files will not be resolved.For
linear/integration-teststhere is norose-app.confand therefore cannot usetweak_iodefso these have been kept at an info level of 50.Any new apps using XML files should use the
$XIOS_INFO_LEVELand also usetweak_iodefas a default command.Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - lfric_apps/run1
Suite Information
Task Information
✅ succeeded tasks - 1165
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review