Skip to content

fix(a11y): sparkline announces formatted values, not raw numbers #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yggdrasilworld wants to merge 1 commit into from
Closed

fix(a11y): sparkline announces formatted values, not raw numbers #751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions src/components/ui/StatCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,10 @@ export function StatCard({
data-testid="statcard-icon"
className="flex h-8 w-8 items-center justify-center rounded-full bg-indigo-50 dark:bg-indigo-500/10"
>
<Icon aria-hidden="true" className="h-4 w-4 text-indigo-600 dark:text-indigo-400" />
<Icon
aria-hidden="true"
className="h-4 w-4 text-indigo-600 dark:text-indigo-400"
/>
</span>
)}
</div>
Expand Down Expand Up @@ -263,9 +266,15 @@ export function StatCard({
)}
>
{trendUp ? (
<ArrowUpRight className="h-3.5 w-3.5 rtl:rotate-90" aria-hidden="true" />
<ArrowUpRight
className="h-3.5 w-3.5 rtl:rotate-90"
aria-hidden="true"
/>
) : (
<ArrowDownRight className="h-3.5 w-3.5 rtl:-rotate-90" aria-hidden="true" />
<ArrowDownRight
className="h-3.5 w-3.5 rtl:-rotate-90"
aria-hidden="true"
/>
)}
{Math.abs(trend)}% vs last period
</p>
Expand All @@ -276,11 +285,21 @@ export function StatCard({
avoids rendering an empty wrapper that leaves an unexplained gap
in this row (#207). */}
{sparkline && sparkline.length >= 2 && (
<div data-testid="statcard-sparkline" className="text-indigo-500 dark:text-indigo-400">
<div
data-testid="statcard-sparkline"
className="text-indigo-500 dark:text-indigo-400"
>
{/* The card's own label becomes the sparkline's accessible name, so
the trend is announced as "Earnings: 8 data points, trending up
from …" rather than as an unlabelled graphic. */}
<Sparkline data={sparkline} label={label} />
from …" rather than as an unlabelled graphic. formatValue makes
the spoken trend match the card's format — without it a currency
card announced raw "1234.5" while the display read "$1,234.50"
(#709). */}
<Sparkline
data={sparkline}
label={label}
formatValue={(v) => formatValue(v, format, asset, locale).display}
/>
</div>
)}
</div>,
Expand Down