Repository navigation
fix(a11y): sparkline announces formatted values, not raw numbers - #751
Closed
yggdrasilworld wants to merge 1 commit into
Closed
yggdrasilworld wants to merge 1 commit into
yggdrasilworld wants to merge 1 commit into
Conversation
StatCard rendered Sparkline without formatValue — describeTrend fell back to String(v), so a currency card announced 'trending from 1234.5' while the display read '$1,234.50'. Pass formatValue derived from the card's format/asset/locale so the spoken trend matches the rendered value. Resolves MergeFi#709
|
@yggdrasilworld is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Rebased onto current main — the equivalent change has already landed upstream (post-rebase diff vs main is empty), so this PR is superseded. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
StatCard rendered
SparklinewithoutformatValue, sodescribeTrendannounced raw numbers ('trending from 1234.5') while the display read '$1,234.50'.Fix
Pass
formatValuederived from the card'sformat/asset/localeso the spoken trend matches the rendered value.Resolves #709
Payment: Base USDC
0xD40Df5c27cEa7dd78A3c345401995c319589334e