Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion folia-phantom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<maven.compiler.target>17</maven.compiler.target>
<asm.version>9.7</asm.version>
<paper.version>1.21.1-R0.1-SNAPSHOT</paper.version>
<javafx.version>21.0.1</javafx.version>
<javafx.version>26.0.1</javafx.version>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep JavaFX on a Java 17/21-compatible line

This bump makes the reactor incompatible with the JDKs we actually build and publish with: CI verifies on Java 17 and 21 (.github/workflows/ci.yml:25) and the release workflow packages on 21 (.github/workflows/release.yml:34), while Oracle documents JavaFX 26 as being for JDK 26 and JavaFX 21 for JDK 17/21. As soon as the GUI module is compiled or the shaded GUI jar is run under those supported JDKs, the JavaFX 26 classes are too new, so this dependency update needs either a matching JDK 26 build/runtime change or to stay on the 21.x line.

Useful? React with 👍 / 👎.

</properties>

<dependencyManagement>
Expand Down
Loading