build(deps): bump javafx.version from 21.0.1 to 26.0.1 in /folia-phantom - #88
build(deps): bump javafx.version from 21.0.1 to 26.0.1 in /folia-phantom#88dependabot[bot] wants to merge 1 commit into
Conversation
Bumps `javafx.version` from 21.0.1 to 26.0.1. Updates `org.openjfx:javafx-controls` from 21.0.1 to 26.0.1 Updates `org.openjfx:javafx-fxml` from 21.0.1 to 26.0.1 --- updated-dependencies: - dependency-name: org.openjfx:javafx-controls dependency-version: 26.0.1 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: org.openjfx:javafx-fxml dependency-version: 26.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc16d21c57
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <asm.version>9.7</asm.version> | ||
| <paper.version>1.21.1-R0.1-SNAPSHOT</paper.version> | ||
| <javafx.version>21.0.1</javafx.version> | ||
| <javafx.version>26.0.1</javafx.version> |
There was a problem hiding this comment.
This bump makes the reactor incompatible with the JDKs we actually build and publish with: CI verifies on Java 17 and 21 (.github/workflows/ci.yml:25) and the release workflow packages on 21 (.github/workflows/release.yml:34), while Oracle documents JavaFX 26 as being for JDK 26 and JavaFX 21 for JDK 17/21. As soon as the GUI module is compiled or the shaded GUI jar is run under those supported JDKs, the JavaFX 26 classes are too new, so this dependency update needs either a matching JDK 26 build/runtime change or to stay on the 21.x line.
Useful? React with 👍 / 👎.
Bumps
javafx.versionfrom 21.0.1 to 26.0.1.Updates
org.openjfx:javafx-controlsfrom 21.0.1 to 26.0.1Updates
org.openjfx:javafx-fxmlfrom 21.0.1 to 26.0.1You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)