Skip to content

fix(rewards): validate denom in FundCommunityPool #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amathxbt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(rewards): validate denom in FundCommunityPool #362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions x/rewards/keeper/keeper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,19 @@ func (k Keeper) Logger(ctx sdk.Context) log.Logger {
// The amount is first added to the rewards module account and then directly
// added to the pool. An error is returned if the amount cannot be sent to the
// module account.
// Only coins whose denom matches the module's configured TokenDenom are accepted;
// funding with a foreign denom would corrupt the single-denom CommunityPool
// invariant and cause subsequent bank sends to fail.
func (k Keeper) FundCommunityPool(ctx context.Context, amount sdk.Coin, sender sdk.AccAddress) error {
params, err := k.Params.Get(ctx)
if err != nil {
return fmt.Errorf("failed to get module params: %w", err)
}
if amount.Denom != params.TokenDenom {
return fmt.Errorf("cannot fund community pool with denom %s: module only accepts %s",
amount.Denom, params.TokenDenom)
}

coins := sdk.Coins{amount}
if err := k.bankKeeper.SendCoinsFromAccountToModule(ctx, sender, types.ModuleName, coins); err != nil {
return err
Expand Down
Loading